-
Notifications
You must be signed in to change notification settings - Fork 787
[SYCL][Driver][thinLTO] Error for -foffload-lto and -fsycl-device-code-split=off #14171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Gen12 failure unrelated, #14186 |
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Please add [ThinLTO] to PR header.
Also, the description says, 'disallow for now'. Do we expect to add this support at a later stage? Do we need a TODO to track this? May be an internal trcker?
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FE change LGTM
@asudarsa Thanks, will update title. I do not plan to add support unless we get an important customer use case, so I don't think we need a TODO/tracker |
This is really complicated to support so we decided to disallow it for now.
I also fixed the condition to be more of what we want.