Skip to content

[SYCL][Driver][thinLTO] Error for -foffload-lto and -fsycl-device-code-split=off #14171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

sarnex
Copy link
Contributor

@sarnex sarnex commented Jun 13, 2024

This is really complicated to support so we decided to disallow it for now.

I also fixed the condition to be more of what we want.

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex
Copy link
Contributor Author

sarnex commented Jun 14, 2024

Gen12 failure unrelated, #14186

@sarnex sarnex marked this pull request as ready for review June 14, 2024 20:13
@sarnex sarnex requested a review from a team as a code owner June 14, 2024 20:13
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex sarnex requested a review from a team as a code owner June 17, 2024 18:27
@sarnex sarnex requested a review from asudarsa June 17, 2024 18:27
@sarnex sarnex temporarily deployed to WindowsCILock June 17, 2024 18:40 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to WindowsCILock June 17, 2024 19:59 — with GitHub Actions Inactive
Copy link
Contributor

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.
Please add [ThinLTO] to PR header.
Also, the description says, 'disallow for now'. Do we expect to add this support at a later stage? Do we need a TODO to track this? May be an internal trcker?

Thanks

Copy link
Contributor

@smanna12 smanna12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE change LGTM

@sarnex
Copy link
Contributor Author

sarnex commented Jun 18, 2024

@asudarsa Thanks, will update title. I do not plan to add support unless we get an important customer use case, so I don't think we need a TODO/tracker

@sarnex sarnex changed the title [SYCL][Driver] Error for -foffload-lto and -fsycl-device-code-split=off [SYCL][Driver][thinLTO] Error for -foffload-lto and -fsycl-device-code-split=off Jun 18, 2024
@sarnex sarnex merged commit e11fecf into intel:sycl Jun 18, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants