Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][E2E] Fix deprecated warnings in InorderQueue e2e tests #14120

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

ayylol
Copy link
Contributor

@ayylol ayylol commented Jun 10, 2024

  • InorderQueue/in_order_get_property.cpp -> Use non-deprecated sycl::exception, add check for errc to ensure we are still catching the correct exception
  • InorderQueue/in_order_kernels.cpp -> Use group get_group_id function instead of deprecated get_id
  • InorderQueue/in_order_usm_implicit.cpp -> Use queue mem_advice function that uses int instead of pi_mem_advice

@ayylol ayylol requested a review from a team as a code owner June 10, 2024 15:29
@ayylol ayylol requested a review from bso-intel June 10, 2024 15:29
@ayylol
Copy link
Contributor Author

ayylol commented Jun 12, 2024

@intel/llvm-gatekeepers This PR is ready to merge :)

@steffenlarsen steffenlarsen merged commit 56f6c24 into intel:sycl Jun 12, 2024
14 checks passed
@ayylol ayylol deleted the e2e-inorderqueue branch June 12, 2024 13:22
ianayl pushed a commit to ianayl/sycl that referenced this pull request Jun 13, 2024
…l#14120)

- `InorderQueue/in_order_get_property.cpp` -> Use non-deprecated
`sycl::exception`, add check for errc to ensure we are still catching
the correct exception
- `InorderQueue/in_order_kernels.cpp` -> Use group `get_group_id`
function instead of deprecated `get_id`
- `InorderQueue/in_order_usm_implicit.cpp` -> Use queue `mem_advice`
function that uses `int` instead of `pi_mem_advice`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants