[SYCL] Add key/value sorting and array input support in SYCL sorting algorithms #13713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrei Fedorov <andrey.fedorov@intel.com>
Updated APIs usage Added testing of sort_key_value_over_group with single values. TODO: Test sort_over_group and sort_key_value_over_group with ranges.
…gfixing It seems that currently tests for array-input APIs pass only when ElementsPerWorkItem == 1. The case when ElementsPerWorkItem > 2 needs fixing.
For some reasons sorting for each WI is not stable.
This was referenced May 24, 2024
againull
added a commit
to againull/llvm
that referenced
this pull request
May 30, 2024
…p_sort extension Current implementation is aligned with the first version of the extension: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_oneapi_group_sort.asciidoc This second version of the extension: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_group_sort.asciidoc changes the API by introducing separate sorter objects for sort_over_group and joint_sort. Save both versions of API until the second version is not fully implemented. When PRs supporting the second version will be fully merged and macro will be updated, then old APIs will be removed. Currently PR doesn't include array input and key/value sorting support. It's split from larger PR: intel#13713 Co-authored-by: "Andrei Fedorov [andrey.fedorov@intel.com](mailto:andrey.fedorov@intel.com)" Co-authored-by: "Romanov Vlad [vlad.romanov@intel.com](mailto:vlad.romanov@intel.com)"
|
Tag @andreyfe1 |
againull
added a commit
to againull/llvm
that referenced
this pull request
Jun 10, 2024
…p_sort extension Current implementation is aligned with the first version of the extension: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_oneapi_group_sort.asciidoc This second version of the extension: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_group_sort.asciidoc changes the API by introducing separate sorter objects for sort_over_group and joint_sort. Save both versions of API until the second version is not fully implemented. When PRs supporting the second version will be fully merged and macro will be updated, then old APIs will be removed. Currently PR doesn't include array input and key/value sorting support. It's split from larger PR: intel#13713 Co-authored-by: "Andrei Fedorov [andrey.fedorov@intel.com](mailto:andrey.fedorov@intel.com)" Co-authored-by: "Romanov Vlad [vlad.romanov@intel.com](mailto:vlad.romanov@intel.com)"
againull
added a commit
that referenced
this pull request
Jun 10, 2024
…p_sort extension (#13908) Current implementation is aligned with the first version of the extension: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_oneapi_group_sort.asciidoc This second version of the extension: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_group_sort.asciidoc changes the API by introducing separate sorter objects for sort_over_group and joint_sort APIs. Save both versions of API until the second version is not fully implemented. When PRs supporting the second version will be fully merged and macro will be updated, then old APIs will be removed. Currently PR doesn't include array input and key/value sorting support. It's split from larger PR: #13713 Co-authored-by: "Andrei Fedorov [andrey.fedorov@intel.com](mailto:andrey.fedorov@intel.com)" Co-authored-by: "Romanov Vlad [vlad.romanov@intel.com](mailto:vlad.romanov@intel.com)"
againull
added a commit
that referenced
this pull request
Jun 12, 2024
Add group_key_value_sorter sorters and sort_key_value_over_group APIs based on https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_group_sort.asciidoc extension. This PR was split out from larger PR: #13713 Co-authored-by: "Andrei Fedorov [andrey.fedorov@intel.com](mailto:andrey.fedorov@intel.com)" Co-authored-by: "Romanov Vlad [vlad.romanov@intel.com](mailto:vlad.romanov@intel.com)"
ianayl
pushed a commit
to ianayl/sycl
that referenced
this pull request
Jun 13, 2024
…p_sort extension (intel#13908) Current implementation is aligned with the first version of the extension: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_oneapi_group_sort.asciidoc This second version of the extension: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_group_sort.asciidoc changes the API by introducing separate sorter objects for sort_over_group and joint_sort APIs. Save both versions of API until the second version is not fully implemented. When PRs supporting the second version will be fully merged and macro will be updated, then old APIs will be removed. Currently PR doesn't include array input and key/value sorting support. It's split from larger PR: intel#13713 Co-authored-by: "Andrei Fedorov [andrey.fedorov@intel.com](mailto:andrey.fedorov@intel.com)" Co-authored-by: "Romanov Vlad [vlad.romanov@intel.com](mailto:vlad.romanov@intel.com)"
ianayl
pushed a commit
to ianayl/sycl
that referenced
this pull request
Jun 13, 2024
Add group_key_value_sorter sorters and sort_key_value_over_group APIs based on https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_group_sort.asciidoc extension. This PR was split out from larger PR: intel#13713 Co-authored-by: "Andrei Fedorov [andrey.fedorov@intel.com](mailto:andrey.fedorov@intel.com)" Co-authored-by: "Romanov Vlad [vlad.romanov@intel.com](mailto:vlad.romanov@intel.com)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODOs before making ready for review:
Co-authored-by: "Andrei Fedorov andrey.fedorov@intel.com"
Co-authored-by: "Romanov Vlad vlad.romanov@intel.com"