[E2E] Modify commands to address running on Windows. #13682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmoadeli
changed the title
mmoadeli
changed the title
mmoadeli
changed the title
|
@intel/llvm-reviewers-runtime, a friendly request to have this reviewed please. |
mmoadeli
changed the title
|
@mmoadeli Why are we dropping the last test where we run the test without the envvar and check that the dot files aren't there? Is this intended? |
thank you @maarquitos14, that is put back. |
ianayl
pushed a commit
to ianayl/sycl
that referenced
this pull request
Jun 13, 2024
Running the test on Windows failed due to missing support of `ls`. Replacing `ls` with `cat` made the test pass on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the test on Windows failed due to missing support of
ls. Replacinglswithcatmade the test pass on Windows.contributor @ldrumm