[SYCL][CUDA] Multiple fixes #1299
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix device query for image support. Fix typo in comment. Init plugin function table to 0. As the PI plugin function table can grow without the CUDA plugin being adapted, set the whole function pointer table to 0 to trigger crashes on calling functions that are not set. Signed-off-by: Bjoern Knafla <bjoern@codeplay.com>
| // functions are not set up below. | ||
| std::memset(&(PluginInit->PiFunctionTable), 0, | ||
| sizeof(PluginInit->PiFunctionTable)); | ||
|
|
||
| // Forward calls to OpenCL RT. |
There was a problem hiding this comment.
OpenCL RT, really? )
There was a problem hiding this comment.
@bjoernknafla, would you like to address this comment before the merge or after?
There was a problem hiding this comment.
Never mind, it will be addressed by #1241.
There was a problem hiding this comment.
Good catch and thank you for tracking it being fixed by @fwyzard !
smaslov-intel
approved these changes
Mar 13, 2020
LGTM, but we should plan using PI version information to detect the out-of-sync |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix device query for image support.
Fix typo in comment.
Init plugin function table to 0.
As the PI plugin function table can grow without the CUDA plugin being
adapted, set the whole function pointer table to 0 to trigger crashes
on calling functions that are not set.
Signed-off-by: Bjoern Knafla bjoern@codeplay.com