Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][ASAN] apply only-needed when link asan libdevice #12849

Merged
merged 3 commits into from
Mar 5, 2024
Merged

[SYCL][ASAN] apply only-needed when link asan libdevice #12849

merged 3 commits into from
Mar 5, 2024

Conversation

jinge90
Copy link
Contributor

@jinge90 jinge90 commented Feb 28, 2024 •
edited
Loading

This patch removes some unused code in sanitizer libdevice and also appied 'only-needed' option when linking libsycl-santizer libdevice.

@jinge90 jinge90 requested review from a team as code owners February 28, 2024 04:52
@jinge90 jinge90 marked this pull request as draft February 28, 2024 04:52
@jinge90
apply only-needed when link asan libdevice
265fc57 
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90 jinge90 marked this pull request as ready for review February 29, 2024 01:12
@jinge90 jinge90 requested a review from AllanZyne February 29, 2024 01:13
@jinge90
add driver lit test to check only-needed for asan devicelib
9225691 
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90 jinge90 requested a review from zhaomaosu March 1, 2024 02:08
zhaomaosu
zhaomaosu approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@zhaomaosu zhaomaosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jinge90
Copy link
Contributor Author

jinge90 commented Mar 1, 2024

Hi, @intel/llvm-reviewers-runtime and @intel/dpcpp-clang-driver-reviewers
Could you take a look at this pr?
Thanks very much.

AllanZyne
AllanZyne approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@AllanZyne AllanZyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinge90
Copy link
Contributor Author

jinge90 commented Mar 4, 2024

Hi, @steffenlarsen
Could you help review this PR?
Thanks very much.

@jinge90 jinge90 temporarily deployed to WindowsCILock March 4, 2024 02:16 — with GitHub Actions Inactive
steffenlarsen
steffenlarsen approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies, @jinge90! LGTM. 👍

@jinge90 jinge90 temporarily deployed to WindowsCILock March 4, 2024 07:16 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock March 4, 2024 07:50 — with GitHub Actions Inactive
@jinge90
Copy link
Contributor Author

jinge90 commented Mar 5, 2024

Hi, @tfzhu
Could you check whether the failure in pre-ci is a infrastructure issue?
Thanks very much.

@jinge90 jinge90 temporarily deployed to WindowsCILock March 5, 2024 02:06 — with GitHub Actions Inactive
@jinge90 jinge90 temporarily deployed to WindowsCILock March 5, 2024 02:07 — with GitHub Actions Inactive
@tfzhu
Copy link
Contributor

tfzhu commented Mar 5, 2024

Hi, @tfzhu Could you check whether the failure in pre-ci is a infrastructure issue? Thanks very much.

passed on re-run. Seems a runner in bad state. Rebooted

@jinge90 jinge90 requested a review from a team March 5, 2024 03:08
@jinge90
Copy link
Contributor Author

jinge90 commented Mar 5, 2024

Hi, @intel/llvm-gatekeepers
Could you help merge this PR?
Thanks very much.

@steffenlarsen steffenlarsen merged commit 7a21f07 into intel:sycl Mar 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steffenlarsen steffenlarsen steffenlarsen approved these changes

@mdtoguchi mdtoguchi mdtoguchi approved these changes

@zhaomaosu zhaomaosu zhaomaosu approved these changes

@AllanZyne AllanZyne AllanZyne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jinge90 @tfzhu @AllanZyne @zhaomaosu @mdtoguchi @steffenlarsen