[SYCL][Driver] Link with sycl libs at link step of clang-cl -fsycl #12793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is addressing the following scenario: clang-cl -I[path to sycl headers] sycl_program.cpp # program compiled but without sycl libs clang-cl -fsycl sycl_program.obj # user expects sycl libs to be linked automatically here. Without this fix this scenario fails at link step because sycl libraries are not pulled in. This scenario already works for clang driver, so only clang-cl needs a fix.
againull
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
againull
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
|
ESIMD/regression/complex-lib-lin.cpp failure unrelated and was seen on another PRs, e.g. #12367 |
These tests are also failing in #12367 and #12783 and are unrelated to this PR. |
mdtoguchi
approved these changes
Feb 22, 2024
Oh, good question, I don't have quick ideas, will need to try experiment locally. |
againull
added a commit
to againull/llvm
that referenced
this pull request
Apr 9, 2024
…fsycl (intel#12793)" This reverts commit d6eecfa.
againull
added a commit
that referenced
this pull request
Apr 9, 2024
…fsycl (#12793)" (#13326) This reverts commit d6eecfa. This was commit was trying to cover the scenario: ``` clang-cl -I[path to sycl headers] sycl_program.cpp clang-cl -fsycl sycl_program.obj ``` and automatically link with sycl library at link step in such case. But problem is that at link step there is no way to know if -fsycl -MDd option was used at compile step or not. if -fsycl -MDd is used at compilation step then driver adds --dependent-lib=msvcrtd --dependent-lib=sycl7d options: `clang-cl -fsycl -MDd sycl_program.cpp # --dependent-lib=msvcrtd --dependent-lib=sycl7d` If then user links the program like this (without -MDd): `clang-cl -fsycl sycl_program.obj` then we will also link with sycl7 library (release version) which will cause a problem. Because at link step we don't know if we need to use debug of release version of the library. So, from my understanding this case: ``` clang-cl -I[path to sycl headers] sycl_program.cpp clang-cl -fsycl sycl_program.obj ``` can't be supported and needs to be considered as user's mistake.
dm-vodopyanov
added a commit
to dm-vodopyanov/llvm
that referenced
this pull request
Apr 24, 2024
dm-vodopyanov
added a commit
that referenced
this pull request
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is addressing the following scenario:
clang-cl -I[path to sycl headers] sycl_program.cpp # program compiled but without sycl libs
clang-cl -fsycl sycl_program.obj # user expects sycl libs to be linked automatically here.
Without this fix this scenario fails at link step because sycl libraries are not pulled in.
This scenario already works for clang driver, so only clang-cl needs a fix.