Skip to content

[SYCL][Graph] Fix memory leaks in new graph tests #12507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

maarquitos14
Copy link
Contributor

Fix memory leaks in newly added graph tests in #12433.

Signed-off-by: Marcos Maronas <marcos.maronas@intel.com>
@maarquitos14
Copy link
Contributor Author

@mfrancepillois FYI.

Copy link
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this

@EwanC
Copy link
Contributor

EwanC commented Jan 29, 2024

tagging @intel/llvm-gatekeepers for merging

@sommerlukas sommerlukas merged commit dbc0272 into intel:sycl Jan 29, 2024
@aelovikov-intel
Copy link
Contributor

aelovikov-intel commented Jan 30, 2024

Post commit failures (for future references/searches):

# Arc GPU:
Failed Tests (2):
  SYCL :: Basic/get_backend.cpp
  SYCL :: USM/usm_pooling.cpp

The first one is known and has been addressed since (IIRC), the second failed like this:

# RUN: at line 22
env UR_L0_DEBUG=1 SYCL_PI_LEVEL_ZERO_USM_RESIDENT=0 SYCL_PI_LEVEL_ZERO_USM_ALLOCATOR=";2M;2M,4,64K" env ONEAPI_DEVICE_SELECTOR=level_zero:gpu  /__w/llvm/llvm/build-e2e/USM/Output/usm_pooling.cpp.tmp.out h 2>&1 | /__w/llvm/llvm/toolchain/bin/FileCheck /__w/llvm/llvm/llvm/sycl/test-e2e/USM/usm_pooling.cpp --check-prefix CHECK-1245
# executed command: env UR_L0_DEBUG=1 SYCL_PI_LEVEL_ZERO_USM_RESIDENT=0 'SYCL_PI_LEVEL_ZERO_USM_ALLOCATOR=;2M;2M,4,64K' env ONEAPI_DEVICE_SELECTOR=level_zero:gpu /__w/llvm/llvm/build-e2e/USM/Output/usm_pooling.cpp.tmp.out h
# note: command had no output on stdout or stderr
# executed command: /__w/llvm/llvm/toolchain/bin/FileCheck /__w/llvm/llvm/llvm/sycl/test-e2e/USM/usm_pooling.cpp --check-prefix CHECK-1245
# note: command had no output on stdout or stderr
# RUN: at line 23
env UR_L0_DEBUG=1 SYCL_PI_LEVEL_ZERO_USM_RESIDENT=0 SYCL_PI_LEVEL_ZERO_USM_ALLOCATOR=";2M;2M,4,64K" env ONEAPI_DEVICE_SELECTOR=level_zero:gpu  /__w/llvm/llvm/build-e2e/USM/Output/usm_pooling.cpp.tmp.out d 2>&1 | /__w/llvm/llvm/toolchain/bin/FileCheck /__w/llvm/llvm/llvm/sycl/test-e2e/USM/usm_pooling.cpp --check-prefix CHECK-1245
# executed command: env UR_L0_DEBUG=1 SYCL_PI_LEVEL_ZERO_USM_RESIDENT=0 'SYCL_PI_LEVEL_ZERO_USM_ALLOCATOR=;2M;2M,4,64K' env ONEAPI_DEVICE_SELECTOR=level_zero:gpu /__w/llvm/llvm/build-e2e/USM/Output/usm_pooling.cpp.tmp.out d
# note: command had no output on stdout or stderr
# error: command failed with exit status: -6
# executed command: /__w/llvm/llvm/toolchain/bin/FileCheck /__w/llvm/llvm/llvm/sycl/test-e2e/USM/usm_pooling.cpp --check-prefix CHECK-1245
# note: command had no output on stdout or stderr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants