Skip to content

Revert "[SYCL][ESIMD]Limit bfloat16 operators to scalars to enable operations with simd vectors (#12089)" #12462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 23, 2024
Merged

Revert "[SYCL][ESIMD]Limit bfloat16 operators to scalars to enable operations with simd vectors (#12089)" #12462

merged 2 commits into from
Jan 23, 2024

Conversation

fineg74
Copy link
Contributor

@fineg74 fineg74 commented Jan 23, 2024

This reverts commit 8c92df9 to address test failures

@fineg74 fineg74 requested review from a team as code owners January 23, 2024 02:56
@fineg74 fineg74 requested a review from cperkinsintel January 23, 2024 02:56
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 23, 2024 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

@v-klochkov
Copy link
Contributor

v-klochkov commented Jan 23, 2024 •
edited
Loading

The summary plan:

  1. Revert the previous fix for bfloat16 - this PR
  2. Add a conservative fix for the issue for ESIMD - SFINAE using std::is_convertible checks
  3. Create a separate tracker/request for SYCL-Language team to address the problem with user/customer types that cannot define various operators to manage user-type and bfloat16 collaboration-rules as user need, e.g. if operator+ for user class and bfloat must work differently - not as conversion to float and operator+.

@v-klochkov v-klochkov merged commit 30a2dae into intel:sycl Jan 23, 2024
@fineg74 fineg74 deleted the bf16 branch January 23, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-klochkov v-klochkov v-klochkov approved these changes

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@cperkinsintel cperkinsintel Awaiting requested review from cperkinsintel cperkinsintel is a code owner automatically assigned from intel/llvm-reviewers-runtime

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fineg74 @v-klochkov @aelovikov-intel