[SYCL][Fusion][NoSTL] Use free functions for configuration management #12445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jopperm
commented
Jan 18, 2024
victor-eds
reviewed
Jan 22, 2024
jopperm
force-pushed
the
kf-nostl/config
branch
from
8efbb2b to
695a2b7
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
jopperm
force-pushed
the
kf-nostl/config
branch
from
695a2b7 to
37d1aee
Compare
victor-eds
reviewed
Jan 23, 2024
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
jopperm
force-pushed
the
kf-nostl/config
branch
from
37d1aee to
fd97fd8
Compare
victor-eds
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Untangle the interaction between options and the
Configclass, and hideConfig(which needs to store options in a map) from the KF interface.The idea is to introduce free functions to interact with the
thread_localinstance ofConfigheld by the existingConfigHelperclass, instead of letting the client construct theConfigobject and handing it to overConfigHelperfor storing it.This PR is part of a series of changes to remove uses of STL classes in the kernel fusion interface to prevent ABI issues in the future.