Skip to content

[CI] Remove old lint task #12308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions .github/workflows/sycl_linux_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -222,13 +222,6 @@ jobs:
cmake --build $GITHUB_WORKSPACE/build --target install-clang-libraries
cmake --build $GITHUB_WORKSPACE/build --target install-llvm-libraries

- name: Install lint utilities
# We install these into our nightly container that CI uses to run lint
# checks.
run: |
cmake --build $GITHUB_WORKSPACE/build --target install-clang-format
cmake --build $GITHUB_WORKSPACE/build --target install-clang-tidy

- name: Pack toolchain
if: ${{ always() && !cancelled() && steps.build.conclusion == 'success' }}
run: tar -I '${{ steps.artifact_info.outputs.COMPRESS }}' -cf ${{ steps.artifact_info.outputs.ARCHIVE_NAME }} -C $GITHUB_WORKSPACE/build/install .
Expand Down
35 changes: 2 additions & 33 deletions .github/workflows/sycl_linux_precommit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,40 +31,9 @@ jobs:
detect_changes:
uses: ./.github/workflows/sycl_detect_changes.yml

lint:
runs-on: [Linux, build]
if: ${{ always() && !contains(github.event.pull_request.labels.*.name, 'disable-lint') }}
container:
image: ghcr.io/intel/llvm/sycl_ubuntu2204_nightly:no-drivers
options: -u 1001:1001
steps:
- uses: actions/checkout@v3
with:
sparse-checkout: |
devops/actions/cached_checkout
devops/actions/clang-format
devops/actions/cleanup
- name: Register cleanup after job is finished
uses: ./devops/actions/cleanup
- name: 'PR commits + 2'
run: echo "PR_FETCH_DEPTH=$(( ${{ github.event.pull_request.commits }} + 2 ))" >> "${GITHUB_ENV}"
- uses: ./devops/actions/cached_checkout
with:
path: src
fetch-depth: ${{ env.PR_FETCH_DEPTH }}
ref: ${{ github.event.pull_request.head.sha }}
merge_ref: ''
cache_path: "/__w/repo_cache/"
- name: Run clang-format
uses: ./devops/actions/clang-format
with:
path: src

build:
needs: [lint, detect_changes]
if: |
always()
&& (success() || needs.lint.result == 'skipped')
needs: [detect_changes]
if: always() && success()
uses: ./.github/workflows/sycl_linux_build.yml
with:
build_ref: ${{ github.sha }}
Expand Down
35 changes: 2 additions & 33 deletions .github/workflows/sycl_windows_precommit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,41 +33,10 @@ jobs:
detect_changes:
uses: ./.github/workflows/sycl_detect_changes.yml

lint:
runs-on: [Linux, build]
if: ${{ always() && !contains(github.event.pull_request.labels.*.name, 'disable-lint') }}
container:
image: ghcr.io/intel/llvm/sycl_ubuntu2204_nightly:no-drivers
options: -u 1001:1001
steps:
- uses: actions/checkout@v3
with:
ref: ${{ github.base_ref }}
sparse-checkout: |
devops/actions/cached_checkout
devops/actions/clang-format
devops/actions/cleanup
- name: Register cleanup after job is finished
uses: ./devops/actions/cleanup
- name: 'PR commits + 2'
run: echo "PR_FETCH_DEPTH=$(( ${{ github.event.pull_request.commits }} + 2 ))" >> "${GITHUB_ENV}"
- uses: ./devops/actions/cached_checkout
with:
path: src
fetch-depth: ${{ env.PR_FETCH_DEPTH }}
ref: ${{ github.event.pull_request.head.sha }}
merge_ref: ''
cache_path: "/__w/repo_cache/"
- name: Run clang-format
uses: ./devops/actions/clang-format
with:
path: src

build:
needs: [lint, detect_changes]
needs: [detect_changes]
if: |
always()
&& (success() || needs.lint.result == 'skipped')
always() && success()
&& github.repository == 'intel/llvm'
uses: ./.github/workflows/sycl_windows_build.yml
with:
Expand Down
32 changes: 0 additions & 32 deletions devops/actions/clang-format/action.yml

This file was deleted.