-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL] refactor annotated_arg operator forwarding #12232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ With the latest revision this PR passed the C/C++ code formatter. |
There seems to be a conflict with the C++ code formatter and lint CI on the clang format Hi @againull do you know about this? |
3db2f04
to
40f8f9f
Compare
sycl/include/sycl/ext/oneapi/experimental/annotated_arg/annotated_arg.hpp
Show resolved
Hide resolved
b703709
to
285f709
Compare
285f709
to
fc9b73d
Compare
fc9b73d
to
34e8cf4
Compare
Hi @againull, the CI has passed except "Check code formatting". It turns out "Check code formatting" and lint have different rules when checking the format. How should I workaround it?
|
I suggest we follow the old lint runs until we have fully migrated, as otherwise we will not get CI results. It will mean we need to bypass branch protection when merging patches with formatter disagreements. @aelovikov-intel - Do you have other preferences? |
I'm going to disable/remove old linter today (unless something goes wrong). Update: uploaded #12308 |
Hi @againull, is this PR ready for merge? |
clang-format is failing, that needs to be fixed before merging. |
Hi @aelovikov-intel, the code format has been fixed |
Refactor annotated_arg operator forwarding regarding to #11971 and #12140