[WIP][SYCL] Replaces some of the CL_* enums with PI_* enums. #1221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rbegam <rehana.begam@intel.com>
Signed-off-by: rbegam <rehana.begam@intel.com>
rbegam
changed the title
Signed-off-by: rbegam <rehana.begam@intel.com>
sub_group::store took T& for host and const T& for device. Signed-off-by: John Pennycook <john.pennycook@intel.com>
bader
reviewed
Feb 29, 2020
Contributor
bader
left a comment
bader
left a comment
There was a problem hiding this comment.
LGTM.
Just a couple of "C++ modernization" suggestions
This patch fixes a sporadic bug where one thread attempted to clean up a command already deleted by another. Signed-off-by: Sergey Semenov <sergey.semenov@intel.com>
…ntel#1224) By default LLVM style limit code lines size to 80 characters. It should not be applied to LIT tests as clang-format can't preserve LIT commands semantic written in the code comments. This configuration file was shamelessly copied from the clang project. Signed-off-by: Alexey Bader <alexey.bader@intel.com>
…ions (intel#1219) Signed-off-by: James Brodman <james.brodman@intel.com>
Signed-off-by: Vladimir Lazarev <vladimir.lazarev@intel.com>
- deploy-lit.site.cfg configuration file used to owerwrite llvm-lit to use binaries from deploy, which sometimes do not exist. Removed deploy-lit.site.cfg and made all configuration files flexible using llvm-lit command line options. - check-all target used to run check-sycl-deploy target. This caused problems if CMAKE_INSTALL_PREFIX wasn't specified, because in this case check-sycl-deploy target leads to trying to install sycl binaries to system directories. Excluded check-sycl-deploy target from check-all. - Reduced copy-paste in check-sycl-deploy target dependencies. - Reduced number of variables passed from cmake to lit. Signed-off-by: Mariya Podchishchaeva <mariya.podchishchaeva@intel.com>
If CUDA initialisation fails or there are no CUDA devices, do not return a CUDA-based SYCL platform rather than aborting or throwing an exception. Signed-off-by: Andrea Bocci <andrea.bocci@cern.ch>
Align `pi.h` formatting style with LLVM formatting style and rest of project. Signed-off-by: Bjoern Knafla <bjoern@codeplay.com>
Align the property parsing of `piContextCreate` with the way OpenCL properties are provided, i.e., a property list contains keys/IDs and values, never just a key/ID. Furthermore enable property lists that just contain a list terminating `0`. Introduce a PI type for context properties to untie from OpenCL. Adapt the SYCL runtime and tests accordingly. Signed-off-by: Bjoern Knafla <bjoern@codeplay.com>
Rehana Begam <rehana.begam@intel.com> Co-Authored-By: Alexey Bader <alexey.bader@intel.com>
Rehana Begam <rehana.begam@intel.com> Co-Authored-By: Alexey Bader <alexey.bader@intel.com>
) This PR fixes the following bugs: 1 Some times upon deletion, the deleted context would stay on the CUDA context stack and cause subsequent CUDA operations to fail. To fix this the context stack is now checked after destruction and if the dead context is still there it is removed. 2 In one location a ScopedContext was created without being assigned to a variable and would therefore die immediately. It should now live for the entirety of the surrounding scope. Signed-off-by: Steffen Larsen <steffen.larsen@codeplay.com>
Signed-off-by: rbegam <rehana.begam@intel.com>
Signed-off-by: rbegam <rehana.begam@intel.com>
Signed-off-by: rbegam <rehana.begam@intel.com>
Signed-off-by: rbegam <rehana.begam@intel.com>
…m/llvm into private/rbegam/sycl-rename
Contributor
|
@rbegam Please, remove commits not related to your patch form PR. |
Contributor
Author
|
@romanovvlad @bader @garimagu I'll close this one soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rehana Begam rehana.begam@intel.com