[CI] Enable pr-code-format workflow for intel/llvm repo #12184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
commented
Dec 14, 2023
| @@ -6,7 +6,7 @@ permissions: | |||
| jobs: | |||
| code_formatter: | |||
| runs-on: ubuntu-latest | |||
There was a problem hiding this comment.
I'd like to start with ubuntu-latest and see how that would work.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Dec 22, 2023
intel#12184 enable format check for python files but we never properly formatted them. Do it now.
steffenlarsen
pushed a commit
that referenced
this pull request
Jan 4, 2024
#12184 enable format check for python files but we never properly formatted them. Do it now.
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Jan 5, 2024
We've enabled the upstream community workflow in intel#12184 after discussion in intel#12085. It's been doing just fine, so the old can be removed now. We now start the build/tests before format checks are finished, but that shouldn't be a problem thanks to intel#11941.
aelovikov-intel
added a commit
that referenced
this pull request
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To experiment with the suggestion in #12085.
Note that
pull_request_targetmeans we cannot test this before we merge it.