[SYCL] Fix dependencies for Doxygen job #1206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
configure.py requires Ninja to be installed on build machine, which is missing from default GitHub Actions Linux environments. Install ninja-build package before proceeding to CMake configuration. Signed-off-by: Alexander Batashev <alexander.batashev@intel.com>
Contributor
|
I don't think it's enough. Did you test this? |
Contributor
Author
I tested it on my fork, configuration step finishes successfully, which is enough for docs to be generated. Is there anything particular that bothers you? |
Contributor
Author
|
@bader by the way, we can temporarily change the trigger to pull request. Deployment will fail, but the rest of the steps must proceed, so that we can be sure that this is enough. |
added 2 commits
February 27, 2020 12:28
Signed-off-by: Alexander Batashev <alexander.batashev@intel.com>
This reverts commit 55b7f37. Signed-off-by: Alexander Batashev <alexander.batashev@intel.com>
bader
approved these changes
Feb 27, 2020
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Feb 23, 2023
…1206) This commit removes the host run and any assumptions and operations related to the host device from the tests in SYCL/ESIMD. Co-authored-by: Sachkov, Alexey <alexey.sachkov@intel.com> Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
configure.py requires Ninja to be installed on build machine, which is
missing from default GitHub Actions Linux environments. Install
ninja-build package before proceeding to CMake configuration.
Signed-off-by: Alexander Batashev alexander.batashev@intel.com