[SYCL][LIBCLC] Allow custom tools location when building libclc #12034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchlanda
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
steffenlarsen
approved these changes
Nov 29, 2023
jchlanda
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jchlanda
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jchlanda
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jchlanda
force-pushed
the
jakub/libclc_custom_tools
branch
from
27f3bf2
to
e4f3832
Compare
|
Failures seem to be a blip in CI, will trigger again. |
jchlanda
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jchlanda
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
Are we aware of any CI issues now, I see CUDA E2E failing: https://github.com/intel/llvm/actions/runs/7089054304/job/19292940897#step:2:119 |
|
We are aware of this failure in the AWS CUDA container. It first appeared around last Friday. |
jchlanda
force-pushed
the
jakub/libclc_custom_tools
branch
from
e4f3832
to
e6c8df3
Compare
jchlanda
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jchlanda
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
jchlanda
force-pushed
the
jakub/libclc_custom_tools
branch
from
e6c8df3
to
b26c4aa
Compare
jchlanda
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jchlanda
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
jsji
pushed a commit
that referenced
this pull request
Dec 21, 2023
Use `LIBCLC_CUSTOM_LLVM_TOOLS_BINARY_DIR` to specify the location of custom toolchain to be used for creation of libclc. This helps with debug build times: * debug build of sycl-toolchain with libclc built with debug tools: ```sh $ for f in $(ls lib/clc/*.bc); touch $f; time ninja sycl-toolchain [0/2] Re-checking globbed directories... [6/6] Generating ../../lib/clc/remangled-l64-signed_char.libspirv-amdgcn-amd-amdhsa.bc ninja sycl-toolchain 682.55s user 1.33s system 112% cpu 10:07.81 total ``` * debug build of sycl-toolchain with libclc built with release tools: ```sh $ for f in $(ls lib/clc/*.bc); touch $f; time ninja sycl-toolchain [0/2] Re-checking globbed directories... [6/6] Generating ../../lib/clc/remangled-l64-signed_char.libspirv-amdgcn-amd-amdhsa.bc ninja sycl-toolchain 158.51s user 1.15s system 189% cpu 1:24.31 total ``` Fixes: #6925
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
LIBCLC_CUSTOM_LLVM_TOOLS_BINARY_DIRto specify the location of custom toolchain to be used for creation of libclc. This helps with debug build times:Fixes: #6925