[Driver][SYCL] Improve dependency file behaviors for -fintelfpga #1186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When compiling AOT for FPGA dependency files are generated that are used by the aoc compilation. Single step compilation is seamless as the dependency file is generated then immediately used. When compiling to object, keeping track of the dependency file is not so intuitive. To alleviate problems of not being able to find the dependency file, the original dependency file is bundled up with the destination fat object and when used is unbundled and passed to the aoc compilation. Signed-off-by: Michael D Toguchi <michael.d.toguchi@intel.com>
Signed-off-by: Michael D Toguchi <michael.d.toguchi@intel.com>
Signed-off-by: Michael D Toguchi <michael.d.toguchi@intel.com>
Use new FPGA dependency type which is used for unbundling of the FPGA dependency from an object. Signed-off-by: Michael D Toguchi <michael.d.toguchi@intel.com>
Signed-off-by: Michael D Toguchi <michael.d.toguchi@intel.com>
Use TY_FPGA_Dependencies for generated file from unbundle Clean up comments and add clang_cl specific test for dep unbundle Signed-off-by: Michael D Toguchi <michael.d.toguchi@intel.com>
Signed-off-by: Michael D Toguchi <michael.d.toguchi@intel.com>
Signed-off-by: Michael D Toguchi <michael.d.toguchi@intel.com>
Signed-off-by: Michael D Toguchi <michael.d.toguchi@intel.com>
|
@bader, are clang-format failures required to be fixed? This test must be new, as I didn't hit it with my previous changes and the bits are the same. |
I think so. I've recently added this check to align with LLVM community, which tries to keep consistent coding style across the code base by using similar pre-commit check. |
Signed-off-by: Michael D Toguchi <michael.d.toguchi@intel.com>
Generating dependency files is not a Windows thing, so the generation of the file was based on the -o option. When using /Fo, the output file name was not being honored. Signed-off-by: Michael D Toguchi <michael.d.toguchi@intel.com>
AGindinson
reviewed
Mar 4, 2020
Signed-off-by: Michael D Toguchi <michael.d.toguchi@intel.com>
AGindinson
previously approved these changes
Mar 4, 2020
Signed-off-by: Michael D Toguchi <michael.d.toguchi@intel.com>
AGindinson
approved these changes
Mar 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling AOT for FPGA dependency files are generated that are used
by the aoc compilation. Single step compilation is seamless as the dependency
file is generated then immediately used. When compiling to object, keeping
track of the dependency file is not so intuitive.
To alleviate problems of not being able to find the dependency file, the
original dependency file is bundled up with the destination fat object and
when used is unbundled and passed to the aoc compilation.
Signed-off-by: Michael D Toguchi michael.d.toguchi@intel.com