[SYCL] Quote CMake command in buildbot.py output #11658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Easier to copy-paste this way. Could be simplified by using shlex.join when Python 3.8 is required.
It looks like some of our internal environment is on '3.7.8'. Can you make it a run-time check somehow? |
Ehh, I am not good at formulating stuff. The current version works fine with 3.7, but the code is too verbose. Once the project switches to 3.8, a simpler solution, just |
aelovikov-intel
approved these changes
Oct 25, 2023
Nope, it's me who's not completely awake yet :) |
omirochn
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easier to copy-paste this way, since many CMake flags contain semicolons.
Could be simplified by using shlex.join when Python 3.8 is required.