[ESIMD][NFC] Fix several NFC issues in atomic_update() implementation #11638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
v-klochkov
commented
Oct 24, 2023
v-klochkov
commented
- Added a routine to convert atomic_op to internal integer opcode that might be different depending on the data type;
- Simplified calls of get_num_args() by removing some redundant LSC <-> non-LSC opcode conversions;
- Use fcmpxchg instead of obsolete/less-common fcmpwr alias-sets;
- Outlined FP types check for atomics into a macro __ESIMD_FP_ATOMIC_OP_TYPE_CHECK that may be re-defined if necessary;
- NFC changes in lsc/atomic_smoke.cpp test to avoid potential problems with some types that may not have all required constexpr constructors.
- Added a routine to convert atomic_op to internal integer opcode that might be different depending on the data type; - Simplified calls of get_num_args() by removing some redundant LSC <-> non-LSC opcode conversions; - Use fcmpxchg instead of obsolete/less-common fcmpwr alias-sets; - Outlined FP types check for atomics into a macro __ESIMD_FP_ATOMIC_OP_TYPE_CHECK that may be re-defined if necessary; - NFC changes in lsc/atomic_smoke.cpp test to avoid potential problems with some types that may not have all required constexpr constructors. Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
v-klochkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
v-klochkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
v-klochkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
turinevgeny
approved these changes
Oct 24, 2023
v-klochkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.