[SYCL] Fix numeric_limits<half> after intel/llvm#1089 #1138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
reviewed
Feb 17, 2020
Error was reproducible in two cases: - using something like `numeric_limits<half>::min()` in within another `constexpr` - not treating SYCL headers as system ones with `-Winvalid-constexpr` treated as error Signed-off-by: Alexey Sachkov <alexey.sachkov@intel.com>
AlexeySachkov
force-pushed
the
private/asachkov/fix-numeric-limit-half
branch
from
b7db5fb to
08da2e8
Compare
|
Please, fix lit test failure. |
This failure is not related to this patch - this is known sporadic issue |
I can't merge until test passes. Who is looking into this issue? |
bader
approved these changes
Feb 25, 2020
vmaksimo
pushed a commit
to vmaksimo/llvm
that referenced
this pull request
Aug 23, 2021
The instruction is for vector types and not for scalar types. It's a kind of a follow up for: KhronosGroup/OpenCL-CTS#1002 Signed-off-by: Dmitry Sidorov <dmitry.sidorov@intel.com> Original commit: KhronosGroup/SPIRV-LLVM-Translator@1a7f142
vmaksimo
pushed a commit
to vmaksimo/llvm
that referenced
this pull request
Sep 28, 2021
This reverts commit 1a7f1420db4dc21a9628b85e9c06073c718ebfc4. The vloada_halfn functions return float vectors: floatn vloada_halfn(size_t offset, const __global half *p) floatn vloada_halfn(size_t offset, const __local half *p) floatn vloada_halfn(size_t offset, const __constant half *p) floatn vloada_halfn(size_t offset, const __private half *p) For the generic address space: floatn vloada_halfn(size_t offset, const half *p) These functions exist specifically for implementations that lack the cl_khr_fp16 extension, and so do not include the halfn vector types, but do include a scalar half type for use as a pointer argument *only*. Likewise, in the SPIR-V OpenCL Extended Instruction Set, the result type for vloada_halfn is defined as follows: Result Type must be vector(2,3,4,8,16) of float values. The assertion added to isBuiltinTransToExtInst(...) is therefore incorrect. The vloada_halfn SPIR-V OpenCL Extended Instruction Set instructions that are emitted for calls to these builtins are accepted by the SPIR-V Validator. Original commit: KhronosGroup/SPIRV-LLVM-Translator@2b95385
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error was reproducible in two cases:
numeric_limits<half>::min()in within anotherconstexpr-Winvalid-constexprtreated as error