[CMake] Enable UR plugin when building dependant plugins #11214
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, only level_zero was adding unified_runtime, but now cuda, hip, and native_cpu require it as well.
al42and
commented
Sep 18, 2023
| @@ -73,61 +73,69 @@ add_sycl_plugin(unified_runtime | |||
| Threads::Threads | |||
| UnifiedRuntimeLoader | |||
| UnifiedRuntime-Headers | |||
| LevelZeroLoader-Headers # we need for #include <ze_api.h> in common.h | |||
There was a problem hiding this comment.
No common.h in sight, and nothing in sycl/plugins/unified_runtime/ rely on level_zero except the corresponding adapter.
jandres742
approved these changes
Sep 22, 2023
bso-intel
approved these changes
Sep 26, 2023
al42and
commented
Sep 26, 2023
Conflicts: sycl/plugins/CMakeLists.txt sycl/plugins/unified_runtime/CMakeLists.txt
|
Will wait for #11566 to be merged before resolving the conflicts here |
|
After the CMake changes associated with moving plugins to the external repo, this PR does not seem to be necessary anymore. At least in my tests, DCP++ builds just fine with OpenCL or HIP alone :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful when building without
level_zeroplugin.