Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Graph] Add support for CUDA backend #11133

Merged
merged 36 commits into from
Nov 3, 2023

Commits on Sep 11, 2023

  1. [SYCL][Graph] Implement graph enqueue for CUDA backend

    Implements urCommandBufferAppendKernelLaunchExp function to append kernel to a command buffer.
    Implements urCommandBufferAppendKernelLaunchExp function to enqueue a command buffer to a cuda stream.
    Enable all tests supported by the current state of the Cuda backend.
    
    Sets a ScopedContext before enqueuing command buffer.
    
    * [SYCL][Graph] Adds missing exception catch
    mfrancepillois committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    c753b8e View commit details
    Browse the repository at this point in the history
  2. [SYCL][Graph] Add support for memory copy operations for CUDA backend

    Implements CUDA backend support for:
    - memcpyUSM
    - memcpy Device to Device (1D and 2D)
    - memcpy Host to Device (Write 1D and 2D)
    - memcpy Device to Host (Read 1D and 2D)
    Enables all remaining e2e tests
    
    * [SYCL][Graph] Adds helper to register sync point
    mfrancepillois committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    d996490 View commit details
    Browse the repository at this point in the history
  3. [SYCL][Graph][DOC] Updates design Doc to report CUDA as supported bac…

    …kend (#309)
    
    * [SYCL][Graph] Updates design Doc to report CUDA as supported backend
    
    * [SYCL][Graph] Improves description and adds links to CUDA doc
    
    * Update sycl/doc/design/CommandGraph.md
    
    Co-authored-by: Ewan Crawford <ewan@codeplay.com>
    
    * Update sycl/doc/design/CommandGraph.md
    
    Co-authored-by: Julian Miller <julian.miller@intel.com>
    
    * Update sycl/doc/design/CommandGraph.md
    
    Co-authored-by: Julian Miller <julian.miller@intel.com>
    
    * Update sycl/doc/design/CommandGraph.md
    
    Co-authored-by: Julian Miller <julian.miller@intel.com>
    
    * Update sycl/doc/design/CommandGraph.md
    
    Co-authored-by: Julian Miller <julian.miller@intel.com>
    
    * Update sycl/doc/design/CommandGraph.md
    
    Co-authored-by: Julian Miller <julian.miller@intel.com>
    
    ---------
    
    Co-authored-by: Ewan Crawford <ewan@codeplay.com>
    Co-authored-by: Julian Miller <julian.miller@intel.com>
    3 people committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    3395b33 View commit details
    Browse the repository at this point in the history
  4. [SYCL][Graph] Implement graph creation and finalization for CUDA back…

    …end (#279)
    
    * [SYCL][Graph] Implement graph creation and finalization for CUDA backend
    
    Implements CommandBuffer creation, retain, release and finalize functions
    for the cuda backend.
    These functions rely on the cuda graph feature which is part of cuda runtime.
    Consequently, this PR adds the required linking dependencies.
    Fixes a commandbuffer bug in the cuda pluging initialization.
    Reports cuda backend as supported for the graph extension.
    Adds a tests that creates and finalizes an empty graph.
    mfrancepillois committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    e367d35 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f6d8258 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3f670e2 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c60ab8f View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. [SYCL][Graph] Improve offset handling in memory copy operations

    The offsets are taken into account after CUdeviceptr type casting.
    mfrancepillois committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    cdc19b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2023

  1. Revert "[SYCL][Graph] Improve offset handling in memory copy operations"

    This patch does not fix e2e test failure on AWS.
    
    This reverts commit cdc19b1.
    mfrancepillois committed Sep 13, 2023
    Configuration menu
    Copy the full SHA
    ca6b445 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2023

  1. Configuration menu
    Copy the full SHA
    9061916 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2023

  1. Configuration menu
    Copy the full SHA
    94e99e8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2ec5a6a View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Configuration menu
    Copy the full SHA
    542511e View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2023

  1. Configuration menu
    Copy the full SHA
    4f333c7 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2023

  1. Configuration menu
    Copy the full SHA
    d4b7e0f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    edd44c9 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. Configuration menu
    Copy the full SHA
    d25c153 View commit details
    Browse the repository at this point in the history
  2. [SYCL][Graph] Wait for deps when adding commands to a command graph

    - Commands which enqueue to a command graph now correctly respect their dependencies by waiting on them.
    - Prevents issues where allocation commands with dependent copies could be delayed due to device being busy and execute in an incorrect order with regards to future command graph executions.
    Bensuo committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    9b984e3 View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2023

  1. Configuration menu
    Copy the full SHA
    b4bda06 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    03f2f5f View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2023

  1. Configuration menu
    Copy the full SHA
    cd99d84 View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2023

  1. Configuration menu
    Copy the full SHA
    262c3db View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2023

  1. Configuration menu
    Copy the full SHA
    0d8c141 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. Configuration menu
    Copy the full SHA
    60a5929 View commit details
    Browse the repository at this point in the history
  2. Update UR tag

    Bensuo committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    b0ae860 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2023

  1. Configuration menu
    Copy the full SHA
    804a04e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    376029b View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2023

  1. Configuration menu
    Copy the full SHA
    ba16929 View commit details
    Browse the repository at this point in the history
  2. Update sycl/plugins/unified_runtime/CMakeLists.txt

    Co-authored-by: Kenneth Benzie (Benie) <k.benzie83@gmail.com>
    EwanC and kbenzie authored Oct 31, 2023
    Configuration menu
    Copy the full SHA
    d9c7ba5 View commit details
    Browse the repository at this point in the history
  3. Fix missing UR tag

    Bensuo committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    0206026 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Configuration menu
    Copy the full SHA
    9a3f722 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    064687d View commit details
    Browse the repository at this point in the history
  3. Update documentation diagram

    EwanC committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    8e3c456 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f3b6b42 View commit details
    Browse the repository at this point in the history
  5. Disable buffer Graph tests for CUDA

    This is a temporary workaround to unblock the UR
    merge queue. We will investigate and fix as follow-up work.
    EwanC committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    f281cd6 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2023

  1. Configuration menu
    Copy the full SHA
    2da75ba View commit details
    Browse the repository at this point in the history