[SYCL][Graph] Make SYCL-Graph functions thread-safe #10778
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [SYCL][Graph] Makes command graph functions thread-safe Addresses comments made on the first PR commit. Mutexes are now added to Graph implementation entry points instead of end points as was the case in the previous commit. Adds "build_pthread_inc" lit test macro to facilitate the compilation of the threading tests. Removes std::barrier (std-20) dependency in threading tests. Addresses Issue: #85 * [SYCL][Graph] Makes command graph functions thread-safe Moves threading tests that do not require a device to run to unitests * Update sycl/source/detail/graph_impl.cpp Co-authored-by: Ben Tracy <ben.tracy@codeplay.com> * [SYCL][Graph] Makes command graph functions thread-safe Adds some comments. * Update sycl/source/handler.cpp Co-authored-by: Pablo Reble <pablo.reble@intel.com> * Update sycl/source/detail/graph_impl.hpp Co-authored-by: Ewan Crawford <ewan@codeplay.com> * [SYCL][Graph] Makes command graph functions thread-safe Adds dedidacted sub-class to unitests for multi-threading unitests * [SYCL][Graph] Makes command graph functions thread-safe Adds comments * [SYCL][Graph] thread-safe: bug fix after rebase --------- Co-authored-by: Ben Tracy <ben.tracy@codeplay.com> Co-authored-by: Pablo Reble <pablo.reble@intel.com> Co-authored-by: Ewan Crawford <ewan@codeplay.com>
Removes the test-e2e dependency to graph_impl.hpp by changing the e2e test to an unitests.
|
Marked this as draft again, as we have discovered that graph enqueue isn't quite thread-safe yet |
This reverts commit 09c1af5.
Fixes memory leak issues that occurred during multithreads graph finalization
Bensuo
approved these changes
Aug 17, 2023
This issue has now been resolved, so PR is Open and ready for review from @intel/llvm-reviewers-runtime |
Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
…this object (#302) The way exec_graph_impl is used and the C++ semantic prevent concurrent access the destructor of this object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the new APIs defined by sycl_ext_oneapi_graph thread safe.
Authors
Co-authored-by: Pablo Reble pablo.reble@intel.com
Co-authored-by: Julian Miller julian.miller@intel.com
Co-authored-by: Ben Tracy ben.tracy@codeplay.com
Co-authored-by: Ewan Crawford ewan@codeplay.com
Co-authored-by: Maxime France-Pillois maxime.francepillois@codeplay.com