Skip to content

[SYCL][Clang][NFC] Fix static analyzer concern #10747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

elizabethandrews
Copy link
Contributor

Fix static analyzer concern about dereferencing null value.

Fix static analyzer concern about dereferencing null value.
@elizabethandrews elizabethandrews requested a review from a team as a code owner August 8, 2023 23:14
@elizabethandrews
Copy link
Contributor Author

@intel/llvm-gatekeepers this PR is ready for merge. Failing tests are unrelated

@dm-vodopyanov dm-vodopyanov changed the title [NFC][Clang] Fix static analyzer concern [SYCL][Clang][NFC] Fix static analyzer concern Aug 9, 2023
@dm-vodopyanov dm-vodopyanov merged commit 0119790 into intel:sycl Aug 9, 2023
@aelovikov-intel
Copy link
Contributor

Failing tests are unrelated

That is not enough, we need at the very least to list the failures here so that they can be found later to gather statistics and help in analysis of flaky failures.

@dm-vodopyanov , please don't merge the PRs with failing tests without that done (or GH issues created).

Failures, HIP:

Failed Tests (2):
  SYCL :: Basic/parallel_for_user_types.cpp
  SYCL :: Basic/queue_priority.cpp

Failed like this:

$ "env" "ONEAPI_DEVICE_SELECTOR=ext_oneapi_hip:gpu" "/__w/llvm/llvm/build-e2e/Basic/Output/parallel_for_user_types.cpp.tmp.out"
# command stderr:
Memory access fault by GPU node-1 (Agent handle: 0x2255d80) on address 0x7f21a0400000. Reason: Page not present or supervisor privilege.

error: command failed with exit status: -6
$ "env" "ONEAPI_DEVICE_SELECTOR=ext_oneapi_hip:gpu" "/__w/llvm/llvm/build-e2e/Basic/Output/queue_priority.cpp.tmp.out"
# command stderr:
Memory access fault by GPU node-1 (Agent handle: 0x228f5b0) on address 0x7f6858600000. Reason: Page not present or supervisor privilege.

@elizabethandrews
Copy link
Contributor Author

Failing tests are unrelated

That is not enough, we need at the very least to list the failures here so that they can be found later to gather statistics and help in analysis of flaky failures.

@dm-vodopyanov , please don't merge the PRs with failing tests without that done (or GH issues created).

Failures, HIP:

Failed Tests (2):
  SYCL :: Basic/parallel_for_user_types.cpp
  SYCL :: Basic/queue_priority.cpp

Failed like this:

$ "env" "ONEAPI_DEVICE_SELECTOR=ext_oneapi_hip:gpu" "/__w/llvm/llvm/build-e2e/Basic/Output/parallel_for_user_types.cpp.tmp.out"
# command stderr:
Memory access fault by GPU node-1 (Agent handle: 0x2255d80) on address 0x7f21a0400000. Reason: Page not present or supervisor privilege.

error: command failed with exit status: -6
$ "env" "ONEAPI_DEVICE_SELECTOR=ext_oneapi_hip:gpu" "/__w/llvm/llvm/build-e2e/Basic/Output/queue_priority.cpp.tmp.out"
# command stderr:
Memory access fault by GPU node-1 (Agent handle: 0x228f5b0) on address 0x7f6858600000. Reason: Page not present or supervisor privilege.

Thanks for the information @aelovikov-intel. I'll do that going forward

mdtoguchi pushed a commit to mdtoguchi/llvm that referenced this pull request Oct 18, 2023
Fix static analyzer concern about dereferencing null value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants