[SYCL] Add missing Intel archs to sycl_ext_oneapi_device_architecture #10716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch updates sycl_ext_oneapi_device_architecture extension with the following: * add missing architecture: * intel_gpu_ehl and its sibling - intel_gpu_jsl * add missing aliases to existing architectures: * intel_gpu_bxt (alias to intel_gpu_apl) * intel_gpu_dg2_g10 (alias to intel_gpu_acm_g10) * intel_gpu_dg2_g11 (alias to intel_gpu_acm_g11) * intel_gpu_dg2_g12 (alias to intel_gpu_acm_g12) * remove unnecessary implementation details for intel_gpu_rpl_s from the driver and make it dependent on intel_gpu_adl_s as they are the same architectures
mdtoguchi
reviewed
Aug 7, 2023
dm-vodopyanov
commented
Aug 7, 2023
AlexeySachkov
approved these changes
Aug 8, 2023
|
@intel/dpcpp-specification-reviewers @againull @intel/llvm-reviewers-runtime, friendly ping |
|
@intel/dpcpp-specification-reviewers @againull @intel/llvm-reviewers-runtime, second ping |
sergey-semenov
approved these changes
Aug 9, 2023
|
@jbrodman @Pennycook, ping |
Pennycook
approved these changes
Aug 9, 2023
|
@dm-vodopyanov I know this is already merged, but could you make a follow-up PR to address one issue? In the specification document, the table describing the available architecture enumerators should also be updated to include the new enumerator values that you added. Thanks! |
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
…intel#10716) This patch updates sycl_ext_oneapi_device_architecture extension with the following: * add missing architecture: * intel_gpu_ehl and its sibling - intel_gpu_jsl * add missing aliases to existing architectures: * intel_gpu_bxt (alias to intel_gpu_apl) * intel_gpu_dg2_g10 (alias to intel_gpu_acm_g10) * intel_gpu_dg2_g11 (alias to intel_gpu_acm_g11) * intel_gpu_dg2_g12 (alias to intel_gpu_acm_g12) * remove unnecessary implementation details for intel_gpu_rpl_s from the driver and make it dependent on intel_gpu_adl_s as they are the same architectures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates sycl_ext_oneapi_device_architecture extension with the following:
add missing architecture:
add missing aliases to existing architectures:
remove unnecessary implementation details for intel_gpu_rpl_s from the driver and make it dependent on intel_gpu_adl_s as they are the same architectures