Skip to content

[SYCL][Bindless] Fix Mipmap Tests #10713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 9, 2023

Conversation

isaacault
Copy link
Contributor

Fix Mipmap Tests

Fixing the computation of expected output values so that the tests also work with input sizes that are not powers of 2.

* Show that mipmaps work with non power of two sizes
* Modify the tests to account for this use case
@isaacault isaacault requested a review from a team as a code owner August 7, 2023 13:55
@isaacault isaacault requested a review from dm-vodopyanov August 7, 2023 13:55
@isaacault isaacault temporarily deployed to aws August 7, 2023 14:01 — with GitHub Actions Inactive
Co-authored-by: Dmitry Vodopyanov <dmitry.vodopyanov@intel.com>
@isaacault isaacault temporarily deployed to aws August 7, 2023 15:04 — with GitHub Actions Inactive
@isaacault isaacault temporarily deployed to aws August 7, 2023 16:19 — with GitHub Actions Inactive
@isaacault isaacault temporarily deployed to aws August 8, 2023 09:53 — with GitHub Actions Inactive
@isaacault isaacault temporarily deployed to aws August 8, 2023 14:20 — with GitHub Actions Inactive
@isaacault
Copy link
Contributor Author

@intel/llvm-gatekeepers Can we get this in please?

@dm-vodopyanov dm-vodopyanov merged commit a2265a6 into intel:sycl Aug 9, 2023
@isaacault isaacault deleted the iault/mipmap_tests_fix branch August 9, 2023 10:04
mdtoguchi pushed a commit to mdtoguchi/llvm that referenced this pull request Oct 18, 2023
# Fix Mipmap Tests

Fixing the computation of expected output values so that the tests also
work with input sizes that are not powers of 2.

---------

Co-authored-by: Dmitry Vodopyanov <dmitry.vodopyanov@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants