[SYCL] Propagate explicitly declared aspects even if excluded #10650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@intel/sycl-language-enabling-triage: FYI |
KornevNikita
reviewed
Aug 2, 2023
sycl/test-e2e/OptionalKernelFeatures/no-fp64-optimization-declared-aspects.cpp
Show resolved
Hide resolved
sycl/test-e2e/OptionalKernelFeatures/no-fp64-optimization-declared-aspects.cpp
Outdated
Show resolved
Hide resolved
maksimsab
reviewed
Aug 3, 2023
sycl/test-e2e/OptionalKernelFeatures/no-fp64-optimization-declared-aspects.cpp
Show resolved
Hide resolved
AlexeySachkov
approved these changes
Aug 8, 2023
KornevNikita
approved these changes
Aug 8, 2023
maarquitos14
reviewed
Aug 8, 2023
Co-authored-by: Marcos Maronas <maarquitos14@users.noreply.github.com>
|
The last commit only contains changes in test comments and previous CI run was green. I will proceed with the merge |
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
…10650) This PR changes `SYCLPropagateAspectsPass` to propagate aspects that come from `sycl_declared_aspects` even if they are excluded. The reason for this change is because a test like `no-fp64-optimization-declared-aspects.cpp` added in this PR would failed before with higher optimization level because - on the first aspect propagation pass, `fp64` is not propagated (to allow for trivial uses of `float x = 1.5` to optimized out) - the call to the function marked with `device_has(fp64)` is inlined on higher optimizations - that function does not actually use `double` in its body which means no usage of double ends up in the optimized function, leading the second aspect propagation pass to not attach `fp64` to its used aspects metadata. --------- Co-authored-by: Alexey Sachkov <alexey.sachkov@intel.com> Co-authored-by: Marcos Maronas <maarquitos14@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
SYCLPropagateAspectsPassto propagate aspects that come fromsycl_declared_aspectseven if they are excluded. The reason for this change is because a test likeno-fp64-optimization-declared-aspects.cppadded in this PR would failed before with higher optimization level becausefp64is not propagated (to allow for trivial uses offloat x = 1.5to optimized out)device_has(fp64)is inlined on higher optimizationsdoublein its bodywhich means no usage of double ends up in the optimized function, leading the second aspect propagation pass to not attach
fp64to its used aspects metadata.