[SYCL][ESIMD] Support get_multi_ptr in ESIMD context #10638
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
accessor::get_pointer is now deprecated in favor of get_multi_ptr. This also fixes a number of tests that use deprecated get_pointer: accessor::get_pointer() has been changed to conform to a recent change to the SYCL specification, where it now returns multi_ptr rather than a raw pointer, where the result of get_pointer is being cast to uintptr_t, and there is no conversion operator from multi_ptr, so it's necessary to retrieve the raw pointer first.
sarnex
approved these changes
Aug 1, 2023
v-klochkov
reviewed
Aug 1, 2023
v-klochkov
approved these changes
Aug 1, 2023
|
Timeout on esimd_emu/dpas_int.cpp is unrelated to this PR. |
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
accessor::get_pointer() is now deprecated in favor of get_multi_ptr. This also fixes a number of tests that use deprecated get_pointer: accessor::get_pointer() has been changed to conform to a recent change to the SYCL specification, where it now returns multi_ptr rather than a raw pointer, where the result of get_pointer is being cast to uintptr_t, and there is no conversion operator from multi_ptr, so it's necessary to retrieve the raw pointer first. get_multi_ptr is used instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accessor::get_pointer is now deprecated in favor of get_multi_ptr.
This also fixes a number of tests that use deprecated get_pointer: accessor::get_pointer() has been changed to conform to a recent change to the SYCL specification, where it now returns multi_ptr rather than a raw pointer, where the result of get_pointer is being cast to uintptr_t, and there is no conversion operator from multi_ptr, so it's necessary to retrieve the raw pointer first. get_multi_ptr is used instead.