[SYCL] Run multiple triples at once in check-sycl #10635
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aelovikov-intel
force-pushed
the
fused-check
branch
from
67450ef to
cf06453
Compare
We don't have complex rules in those tests so it should be easy to update the tests to support this scenario. It should save use about 2-3 out of 8 minutes for the `check-sycl` target by reducing number of host compilations.
aelovikov-intel
force-pushed
the
fused-check
branch
from
cf06453 to
c09a236
Compare
aelovikov-intel
changed the title
aelovikov-intel
commented
Aug 1, 2023
looks unrelated as nothing about E2E tests has been changed here. Reviewers (@intel/dpcpp-esimd-reviewers , @intel/llvm-reviewers-runtime , @steffenlarsen), ping. |
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Aug 8, 2023
Single triple targets are only meant for manual run and should not be included into check-all, only check-sycl-combined-triples should be. Otherwise we are running the same tests from multiple processes resulting in race conditions (beside unnecessary work).
jsji
added a commit
that referenced
this pull request
Aug 8, 2023
aelovikov-intel
added a commit
that referenced
this pull request
Aug 8, 2023
Single triple targets are only meant for manual run and should not be included into check-all, only check-sycl-combined-triples should be. Otherwise we are running the same tests from multiple processes resulting in race conditions (beside unnecessary work).
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
We don't have complex rules in those tests so it is easy to update the tests to support this scenario. It should save us about 2-3 out of 8-10 minutes for the `check-sycl` target by reducing number of host compilations.
mdtoguchi
pushed a commit
to mdtoguchi/llvm
that referenced
this pull request
Oct 18, 2023
Single triple targets are only meant for manual run and should not be included into check-all, only check-sycl-combined-triples should be. Otherwise we are running the same tests from multiple processes resulting in race conditions (beside unnecessary work).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have complex rules in those tests so it is easy to update the
tests to support this scenario. It should save us about 2-3 out of
8-10 minutes for the
check-sycltarget by reducing number of hostcompilations.