Fix missing types in Ubuntu 22 #10604
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
reviewed
Jul 28, 2023
| @@ -11,6 +11,7 @@ | |||
| #include <sycl/detail/defines_elementary.hpp> | |||
|
|
|||
| #include <iterator> | |||
| #include <memory> | |||
There was a problem hiding this comment.
@jsji, could you point to the declaration from memory header we use in sycl/include/sycl/detail/stl_type_traits.hpp. I don't see anything that needs this include.
We met build failure in building sycl cts on Ubuntu 22 after #10458.
We use Ubuntu 22 in our CI. We don't run SYCL-CTS, but I'm sure our end-to-end tests cover most of SYCL functionality. I suppose it might be related to GNU standard library version on your Ubuntu 22 system.
|
#10605 should address the problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We met build failure in building sycl cts on Ubuntu 22 after #10458.
quite some types are not defined
unknown type name 'uint16_t'
This is to restore include of to fix the failures.