Skip to content

[SYCL] Fix HIP plugin codeowners #10580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

steffenlarsen
Copy link
Contributor

HIP plugin codeownership currently falls to L0 reviewers. A more appropriate group for owning this plugin is the CUDA plugin maintainers. In the future we can consider splitting the ownership or rename the CUDA reviewers group to encapsulate both.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
@steffenlarsen steffenlarsen requested a review from bader as a code owner July 26, 2023 15:50
@bader bader requested review from a team and npmiller and removed request for a team July 26, 2023 15:57
@bader
Copy link
Contributor

bader commented Jul 26, 2023

@intel/llvm-reviewers-cuda, are you okay to own HIP plug-in code?

Copy link
Contributor

@npmiller npmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, we also work on the HIP plugin and it's very similar to the CUDA plugin.

@bader bader merged commit 712878c into intel:sycl Jul 26, 2023
mdtoguchi pushed a commit to mdtoguchi/llvm that referenced this pull request Oct 18, 2023
HIP plugin codeownership currently falls to L0 reviewers. A more
appropriate group for owning this plugin is the CUDA plugin maintainers.
In the future we can consider splitting the ownership or rename the CUDA
reviewers group to encapsulate both.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants