Skip to content

Conversation

@jle-quel
Copy link
Contributor

@jle-quel jle-quel commented Jul 25, 2023

This PR proposed the modification of the sycl::complex's extension be moved from ./proposed to ./experimental, respecting the sycl/doc/extensions/README: The sycl::complex is implemented but may change in the future.

Reference PR: #9867

@abagusetty @gmlueck @steffenlarsen @AerialMantis

@jle-quel jle-quel requested a review from a team as a code owner July 25, 2023 14:35
@jle-quel jle-quel changed the title [SYCL][DOC] Move sycl::complex's extension from proposed to experimental [SYCL][DOC] Update and Move sycl::complex's extension from proposed to experimental Jul 25, 2023
Copy link
Contributor

@gmlueck gmlueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this PR contains all of the changes from #9867, which is why there are so many differences between the old "proposed" extension and the new "experimental" one.

I verified that the file in this PR is the same as the one in #9867. There's just one minor comment with the copyright date.

Co-authored-by: Greg Lueck <gregory.m.lueck@intel.com>
@jle-quel
Copy link
Contributor Author

Precommit failure seems to be an infrastructure hiccup.

@steffenlarsen steffenlarsen merged commit ea6aea3 into intel:sycl Jul 27, 2023
@jle-quel jle-quel deleted the jle-quel/update-and-move-complex-extension-to-experimental branch July 27, 2023 10:56
mdtoguchi pushed a commit to mdtoguchi/llvm that referenced this pull request Oct 18, 2023
…o experimental (intel#10553)

This PR proposed the modification of the sycl::complex's extension be
moved from ```./proposed``` to ```./experimental```, respecting the
```sycl/doc/extensions/README```: The ```sycl::complex``` is implemented
but may change in the future.

Reference PR: intel#9867

@abagusetty @gmlueck @steffenlarsen @AerialMantis

---------

Co-authored-by: Greg Lueck <gregory.m.lueck@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants