Skip to content

[ReachingDefinition] Remove assert to always find underlying value #10530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 24, 2023
Merged

[ReachingDefinition] Remove assert to always find underlying value #10530

merged 1 commit into from
Jul 24, 2023

Conversation

whitneywhtsang
Copy link
Contributor

May not always be possible to get a single underlying value from UnderlyingValueAnalysis.
UnderlyingValueAnalysis should be improved to handle multiple underlying values from multiple callers.

@whitneywhtsang
[ReachingDefinition] Remove assert to always find underlying value
6aaf38d 
Signed-off-by: Tsang, Whitney <whitney.tsang@intel.com>
@whitneywhtsang whitneywhtsang added the sycl-mlir Pull requests or issues for sycl-mlir branch label Jul 22, 2023
@whitneywhtsang whitneywhtsang requested a review from jopperm July 22, 2023 02:14
@whitneywhtsang whitneywhtsang self-assigned this Jul 22, 2023
@whitneywhtsang whitneywhtsang mentioned this pull request Jul 23, 2023
Merged
sommerlukas
sommerlukas approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@sommerlukas sommerlukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you create an issue for the improvement of the UnderlyingValueAnalysis, so we don't forget about it?

@whitneywhtsang whitneywhtsang mentioned this pull request Jul 24, 2023
Open
@whitneywhtsang
Copy link
Contributor Author

LGTM. Can you create an issue for the improvement of the UnderlyingValueAnalysis, so we don't forget about it?

Created #10536.

@whitneywhtsang whitneywhtsang merged commit 48b2c70 into intel:sycl-mlir Jul 24, 2023
@whitneywhtsang whitneywhtsang deleted the underlyingval_assert branch July 24, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jopperm jopperm jopperm approved these changes

@sommerlukas sommerlukas sommerlukas approved these changes

@etiotto etiotto Awaiting requested review from etiotto

@Naghasan Naghasan Awaiting requested review from Naghasan

@victor-eds victor-eds Awaiting requested review from victor-eds

Assignees

@whitneywhtsang whitneywhtsang

Labels
sycl-mlir Pull requests or issues for sycl-mlir branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@whitneywhtsang @jopperm @sommerlukas