Skip to content

[SYCL][NFC] Remove __SYCL_INLINE_VER_NAMESPACE macro #10510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 21, 2023

Conversation

bader
Copy link
Contributor

@bader bader commented Jul 21, 2023

No description provided.

@bader bader requested a review from againull July 21, 2023 04:20
@bader
Copy link
Contributor Author

bader commented Jul 21, 2023

Note for reviewers.
99% of changes are done with "find and replace": __SYCL_INLINE_VER_NAMESPACE(_V1) to inline namespace _V1. clang-format adds a comment // namespace _V1 i.e. inline is dropped in the closing comment.

There are just a few files worth reviewing:

  1. sycl/.clang-format
  2. sycl/doc/doxygen.cfg.in
  3. sycl/include/sycl/detail/defines_elementary.hpp and clang/test/SemaSYCL/Inputs/sycl/detail/defines_elementary.hpp

@bader bader temporarily deployed to aws July 21, 2023 04:45 — with GitHub Actions Inactive
@bader bader temporarily deployed to aws July 21, 2023 05:23 — with GitHub Actions Inactive
Copy link
Contributor

@sommerlukas sommerlukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewed the following files relating to kernel fusion, those look good.

fusion_properties.hpp
fusion_wrapper.hpp
fusion_wrapper.cpp
fusion_wrapper_impl.cpp
fusion_wrapper_impl.hpp
jit_compiler.cpp
jit_compiler.hpp
jit_device_binaries.cpp
jit_device_binaries.hpp

Copy link
Contributor

@PietroGhg PietroGhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Native CPU LGTM

Copy link
Contributor

@premanandrao premanandrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE changes look okay to me. (I reviewed just a few random files.)

Copy link
Contributor

@steffenlarsen steffenlarsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bader bader temporarily deployed to aws July 21, 2023 16:36 — with GitHub Actions Inactive
@bader bader temporarily deployed to aws July 21, 2023 17:15 — with GitHub Actions Inactive
@bader bader temporarily deployed to aws July 21, 2023 17:54 — with GitHub Actions Inactive
@bader bader temporarily deployed to aws July 21, 2023 18:32 — with GitHub Actions Inactive
@bader bader merged commit 9568e36 into intel:sycl Jul 21, 2023
@bader bader deleted the remove-include branch July 21, 2023 18:58
@bader
Copy link
Contributor Author

bader commented Jul 21, 2023

@intel/llvm-gatekeepers, FYI.
Please, make sure that "ready to merge" patches don't add new uses of __SYCL_INLINE_VER_NAMESPACE macro. The best way to validate is to merge tip of the sycl branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants