-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL][NFC] Remove __SYCL_INLINE_VER_NAMESPACE macro #10510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note for reviewers. There are just a few files worth reviewing:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only reviewed the following files relating to kernel fusion, those look good.
fusion_properties.hpp
fusion_wrapper.hpp
fusion_wrapper.cpp
fusion_wrapper_impl.cpp
fusion_wrapper_impl.hpp
jit_compiler.cpp
jit_compiler.hpp
jit_device_binaries.cpp
jit_device_binaries.hpp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Native CPU LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FE changes look okay to me. (I reviewed just a few random files.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@intel/llvm-gatekeepers, FYI. |
No description provided.