Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Driver][SYCL] Diagnose SYCL options in non-sycl mode. #10502

Merged
merged 7 commits into from
Jul 25, 2023
Merged

[Driver][SYCL] Diagnose SYCL options in non-sycl mode. #10502

merged 7 commits into from
Jul 25, 2023

Conversation

srividya-sundaram
Copy link
Contributor

No description provided.

@srividya-sundaram srividya-sundaram temporarily deployed to aws July 20, 2023 20:56 — with GitHub Actions Inactive
@srividya-sundaram srividya-sundaram temporarily deployed to aws July 20, 2023 23:18 — with GitHub Actions Inactive
@srividya-sundaram srividya-sundaram temporarily deployed to aws July 21, 2023 17:27 — with GitHub Actions Inactive
@srividya-sundaram srividya-sundaram temporarily deployed to aws July 21, 2023 18:05 — with GitHub Actions Inactive
@srividya-sundaram srividya-sundaram changed the title [Driver][SYCL] Disgnose SYCL options in non-sycl mode. [Driver][SYCL] Diagnose SYCL options in non-sycl mode. Jul 21, 2023
@srividya-sundaram srividya-sundaram temporarily deployed to aws July 21, 2023 22:50 — with GitHub Actions Inactive
@srividya-sundaram srividya-sundaram temporarily deployed to aws July 21, 2023 23:29 — with GitHub Actions Inactive
@srividya-sundaram srividya-sundaram temporarily deployed to aws July 21, 2023 23:53 — with GitHub Actions Inactive
@srividya-sundaram srividya-sundaram temporarily deployed to aws July 22, 2023 00:34 — with GitHub Actions Inactive
mdtoguchi
mdtoguchi approved these changes Jul 22, 2023
View reviewed changes
Copy link
Contributor

@mdtoguchi mdtoguchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@srividya-sundaram srividya-sundaram marked this pull request as ready for review July 22, 2023 01:10
@srividya-sundaram srividya-sundaram requested review from a team as code owners July 22, 2023 01:10
@srividya-sundaram srividya-sundaram temporarily deployed to aws July 22, 2023 01:12 — with GitHub Actions Inactive
@srividya-sundaram
Copy link
Contributor Author

@intel/llvm-gatekeepers Hi, this is ready for merge.
The failures in pre-commit checks are un-related to this PR. Thanks.

@aelovikov-intel
Copy link
Contributor

Please merge latest origin/sycl to re-test. HIP failure looks to be infrastructure-related and hopefully will be fixed once you update your branch.

@srividya-sundaram srividya-sundaram temporarily deployed to aws July 24, 2023 17:01 — with GitHub Actions Inactive
@srividya-sundaram srividya-sundaram temporarily deployed to aws July 24, 2023 17:45 — with GitHub Actions Inactive
@srividya-sundaram
Copy link
Contributor Author

Please merge latest origin/sycl to re-test. HIP failure looks to be infrastructure-related and hopefully will be fixed once you update your branch.

@aelovikov-intel I have merged the latest sources from Origin/sycl into this branch, which seemed to have fixed the infrastructure error. But the Jenkins/Precommit fails with this error now - Build failed with Error: hudson.AbortException: script returned exit code 255

And I see a lot of test failures in SYCL Pre Commit on Linux / Linux / e2e-tests (hip_amdgpu, HIP AMDGPU LLVM Test Suite that seem un-related to my changes in this PR.

@aelovikov-intel
Copy link
Contributor

I believe the infrastructure issue for HIP has been fixed in a0056b7 which happened about an hour after your restart. The changes seem very unlikely to affect HIP in any specific way so I'll merge it as-is.

@aelovikov-intel aelovikov-intel merged commit bf128c8 into intel:sycl Jul 25, 2023
15 of 16 checks passed
mdtoguchi pushed a commit to mdtoguchi/llvm that referenced this pull request Oct 18, 2023
@srividya-sundaram @mdtoguchi
[Driver][SYCL] Diagnose SYCL options in non-sycl mode. (intel#10502)
09b4343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@premanandrao premanandrao premanandrao left review comments

@mdtoguchi mdtoguchi mdtoguchi approved these changes

@elizabethandrews elizabethandrews elizabethandrews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@srividya-sundaram @aelovikov-intel @premanandrao @mdtoguchi @elizabethandrews