Skip to content

[SYCL][CUDA] Fix device creation from native handle #10450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kbenzie
Copy link
Contributor

@kbenzie kbenzie commented Jul 18, 2023

In CUDA objects are represented as integers rather than opaque handles.
This patch fixes a segmentation fault when creating a device handle from
a native handle by avoiding dereferencing a pointer which should be
treated as an integer.

In CUDA objects are represented as integers rather than opaque handles.
This patch fixes a segmentation fault when creating a device handle from
a native handle by avoiding dereferencing a pointer which should be
treated as an integer.
@kbenzie kbenzie requested a review from a team as a code owner July 18, 2023 10:26
@kbenzie kbenzie requested a review from jchlanda July 18, 2023 10:27
@kbenzie kbenzie temporarily deployed to aws July 18, 2023 10:41 — with GitHub Actions Inactive
@kbenzie kbenzie temporarily deployed to aws July 18, 2023 11:20 — with GitHub Actions Inactive
@kbenzie
Copy link
Contributor Author

kbenzie commented Jul 19, 2023

@intel/llvm-gatekeepers this bugfix is ready to merge

@dm-vodopyanov dm-vodopyanov merged commit 53ab22c into intel:sycl Jul 19, 2023
@kbenzie kbenzie deleted the benie/fix-cuda-urDeviceCreateWithNativeHandle branch July 19, 2023 12:39
fabiomestre pushed a commit to fabiomestre/llvm that referenced this pull request Sep 26, 2023
In CUDA objects are represented as integers rather than opaque handles.
This patch fixes a segmentation fault when creating a device handle from
a native handle by avoiding dereferencing a pointer which should be
treated as an integer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants