Skip to content

[SYCL] Reorganize annotated_arg/ptr folder #10420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 21, 2023
Merged

[SYCL] Reorganize annotated_arg/ptr folder #10420

merged 6 commits into from
Jul 21, 2023

Conversation

broxigarchen
Copy link
Contributor

@broxigarchen broxigarchen commented Jul 17, 2023 •
edited
Loading

Reorganize annotated_ptr/arg folder

sycl/ext
----oneapi/
--------experimental
--------------annotated_ptr
--------------------annotated_ptr.hpp
--------------annotated_arg
--------------------annotated_arg.hpp
--------------common_annotated_properties
--------------------properties.hpp
----intel/
--------experimental
--------------fpga_annotated_properties.hpp
--------------fpga_kernel_properties.hpp

@broxigarchen broxigarchen changed the title reorganize annotated_arg/ptr folder [SYCL] reorganize annotated_arg/ptr folder Jul 17, 2023
tiwaria1
tiwaria1 reviewed Jul 17, 2023
View reviewed changes
sycl/include/sycl/ext/oneapi/common_annotated_properties/properties.hpp Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this under ext/oneapi instead of ext/intel?

Copy link
Contributor Author

@broxigarchen broxigarchen Jul 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a mistake on the namespace. Corrected.

For the common properties under oneAPI. For now we have "restrict", but it's not implemented yet.
https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_oneapi_kernel_arg_properties.asciidoc

This is a place holder and also holding some utilities

@broxigarchen broxigarchen reopened this Jul 17, 2023
@broxigarchen broxigarchen marked this pull request as ready for review July 17, 2023 17:56
@broxigarchen broxigarchen requested a review from a team as a code owner July 17, 2023 17:56
@broxigarchen broxigarchen temporarily deployed to aws July 17, 2023 19:27 — with GitHub Actions Inactive
@broxigarchen
Copy link
Contributor Author

Hi @dm-vodopyanov can you help to review this PR? We want to get this in before CC.

@broxigarchen broxigarchen temporarily deployed to aws July 17, 2023 22:37 — with GitHub Actions Inactive
@broxigarchen broxigarchen temporarily deployed to aws July 17, 2023 23:21 — with GitHub Actions Inactive
@broxigarchen broxigarchen temporarily deployed to aws July 18, 2023 05:45 — with GitHub Actions Inactive
@broxigarchen broxigarchen temporarily deployed to aws July 18, 2023 06:37 — with GitHub Actions Inactive
@dm-vodopyanov dm-vodopyanov changed the title [SYCL] reorganize annotated_arg/ptr folder [SYCL] Reorganize annotated_arg/ptr folder Jul 18, 2023
@broxigarchen @dm-vodopyanov
correct file name
0a9ae5a 
Co-authored-by: Dmitry Vodopyanov <dmitry.vodopyanov@intel.com>
@broxigarchen broxigarchen temporarily deployed to aws July 18, 2023 18:26 — with GitHub Actions Inactive
@broxigarchen broxigarchen temporarily deployed to aws July 18, 2023 19:11 — with GitHub Actions Inactive
@dm-vodopyanov
Copy link
Contributor

@broxigarchen, please update the branch because of many failures in Intel CPU/GEN9 GPU check.

@broxigarchen broxigarchen temporarily deployed to aws July 19, 2023 00:53 — with GitHub Actions Inactive
@broxigarchen broxigarchen temporarily deployed to aws July 19, 2023 01:33 — with GitHub Actions Inactive
@dm-vodopyanov
Copy link
Contributor

@broxigarchen this will be an API break inside one release, or API break between releases?

@broxigarchen
Copy link
Contributor Author

@broxigarchen this will be an API break inside one release, or API break between releases?

This will be no API break. This is a new feature starting from this release

@broxigarchen broxigarchen temporarily deployed to aws July 20, 2023 12:48 — with GitHub Actions Inactive
@broxigarchen broxigarchen temporarily deployed to aws July 20, 2023 12:53 — with GitHub Actions Inactive
@broxigarchen broxigarchen temporarily deployed to aws July 20, 2023 18:09 — with GitHub Actions Inactive
@broxigarchen broxigarchen temporarily deployed to aws July 20, 2023 18:51 — with GitHub Actions Inactive
@broxigarchen broxigarchen temporarily deployed to aws July 20, 2023 19:09 — with GitHub Actions Inactive
@broxigarchen broxigarchen temporarily deployed to aws July 20, 2023 19:49 — with GitHub Actions Inactive
@broxigarchen
Copy link
Contributor Author

Hi @intel/llvm-gatekeepers can you help to merge this? Thanks!

@dm-vodopyanov
Copy link
Contributor

@broxigarchen this will be an API break inside one release, or API break between releases?

This will be no API break. This is a new feature starting from this release

@broxigarchen to double-check, this patch will be cherry-picked to internal repo, correct?

@dm-vodopyanov dm-vodopyanov merged commit 80b7de1 into intel:sycl Jul 21, 2023
@broxigarchen
Copy link
Contributor Author

@broxigarchen this will be an API break inside one release, or API break between releases?

This will be no API break. This is a new feature starting from this release

@broxigarchen to double-check, this patch will be cherry-picked to internal repo, correct?

Yes

bader
bader reviewed Jul 21, 2023
View reviewed changes
sycl/include/sycl/ext/intel/experimental/fpga_annotated_properties.hpp
Comment on lines +1 to +2
//==-- fpga_annotated_properties.hpp - SYCL properties associated with
// annotated_arg/ptr --==//
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@broxigarchen, formatting if off here and in sycl/include/sycl/ext/oneapi/experimental/common_annotated_properties/properties.hpp.

mdtoguchi pushed a commit to mdtoguchi/llvm that referenced this pull request Oct 18, 2023
@dm-vodopyanov @mdtoguchi
[SYCL] Reorganize annotated_arg/ptr folder (intel#10420)
da3ef37 
Reorganize annotated_ptr/arg folder

sycl/ext
----oneapi/
--------experimental
--------------annotated_ptr
--------------------annotated_ptr.hpp
--------------annotated_arg
--------------------annotated_arg.hpp
--------------common_annotated_properties
--------------------properties.hpp
----intel/
--------experimental
--------------fpga_annotated_properties.hpp
--------------fpga_kernel_properties.hpp

---------

Co-authored-by: Dmitry Vodopyanov <dmitry.vodopyanov@intel.com>
@againull againull mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bader bader bader left review comments

@tiwaria1 tiwaria1 tiwaria1 left review comments

@dm-vodopyanov dm-vodopyanov dm-vodopyanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@broxigarchen @dm-vodopyanov @bader @tiwaria1