Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] More cleanup for the lint task #10073

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Conversation

aelovikov-intel
Copy link
Contributor

No description provided.

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner June 26, 2023 17:32
@aelovikov-intel
Copy link
Contributor Author

Tested via https://github.com/intel/llvm/actions/runs/5381209434 + manual monitoring of the filesystem on the runner.

@aelovikov-intel aelovikov-intel merged commit 7e98cd4 into sycl Jun 26, 2023
@aelovikov-intel aelovikov-intel deleted the sycl-devops-pr/more-cleanup branch June 26, 2023 17:45
@@ -1,3 +1,4 @@
const path = process.env.GITHUB_WORKSPACE + '/*';
console.log('Cleaning ' + path)
require('child_process').execSync('rm -rf ' + path);
require('child_process').execSync('rm -rf ' + process.env.GITHUB_WORKSPACE + '/.git');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to remove all hidden files/directories and not just .git?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, yes, but I don't know how to do that (or if any task creates such files). I needed this change urgently for #10074. We can follow up with a generic solution later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using const path = process.env.GITHUB_WORKSPACE + '/{*,.*}'; at line 1 should work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will prepare a PR with this tomorrow - want to give #10074 more time to expose any potential issues post-commit on its own (although I hope that none would appear, of course).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants