-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] More cleanup for the lint task #10073
Conversation
Tested via https://github.com/intel/llvm/actions/runs/5381209434 + manual monitoring of the filesystem on the runner. |
@@ -1,3 +1,4 @@ | |||
const path = process.env.GITHUB_WORKSPACE + '/*'; | |||
console.log('Cleaning ' + path) | |||
require('child_process').execSync('rm -rf ' + path); | |||
require('child_process').execSync('rm -rf ' + process.env.GITHUB_WORKSPACE + '/.git'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we want to remove all hidden files/directories and not just .git
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, yes, but I don't know how to do that (or if any task creates such files). I needed this change urgently for #10074. We can follow up with a generic solution later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
using const path = process.env.GITHUB_WORKSPACE + '/{*,.*}';
at line 1 should work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will prepare a PR with this tomorrow - want to give #10074 more time to expose any potential issues post-commit on its own (although I hope that none would appear, of course).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No description provided.