This patch 1. refactors SYCL kernel function attribute reqd_work_group_size to better fit for community standards. 2. refactors the way we handled duplicate attributes logic with when present on a given declaration. 3. refactors the way we handled mutually exclusive attributes logic with when present on a given declaration with reqd_work_group_size, max_work_group_size, max_global_work_dim, and num_simd_work_items attributes. 5. handles redeclarations or template instantiations properly. 6. stores ConstantExpr into the semantic attribute rather than calling getIntegerConstantExpr() for attribute dimension values. 7. fixes crash with optional arguments on ReqdWorkGroupAttr and adds missing diagnostics for merging cases when present on a given declaration with reqd_work_group_size, max_work_group_size, max_global_work_dim, and num_simd_work_items attributes. 8. updates clang-tidy build after reqd_work_group_size attribute changes. 9. adds tests. This patch fixes #5736, #5735, #5734, #5732, #5731, #3223, #3361, #3175, #3742, and #5733 Signed-off-by: Soumi Manna <soumi.manna@intel.com>

Refactor of reqd_work_group_size and max_work_group_size attributes #3742

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions