Issues with `make deploy-sycl-toolchain`

[fwyzard]

After configuring with

cmake \
  -DCMAKE_BUILD_TYPE=$BUILD_TYPE \
  -DCMAKE_INSTALL_PREFIX=$INSTALL_PATH \
  -DLLVM_TARGETS_TO_BUILD="X86;PowerPC;AArch64;NVPTX" \
  -DLLVM_EXTERNAL_PROJECTS="llvm-spirv;sycl;opencl-aot" \
  -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra;compiler-rt;lld;openmp;llvm-spirv;sycl;opencl-aot;libclc" \
  -DLLVM_EXTERNAL_SYCL_SOURCE_DIR=$SYCL_BASE/llvm/sycl \
  -DLLVM_EXTERNAL_LLVM_SPIRV_SOURCE_DIR=$SYCL_BASE/llvm/llvm-spirv \
  -DLLVM_ENABLE_EH=ON \
  -DLLVM_ENABLE_PIC=ON \
  -DLLVM_ENABLE_RTTI=ON \
  -DLLVM_LIBDIR_SUFFIX=64 \
  -DBUILD_SHARED_LIBS=OFF \
  -DLIBCLC_TARGETS_TO_BUILD="nvptx64--;nvptx64--nvidiacl" \
  -DSYCL_BUILD_PI_CUDA=ON \
  -DCUDA_TOOLKIT_ROOT_DIR=$CUDA_BASE \
  -DCUDA_USE_STATIC_CUDA_RUNTIME=OFF \
   $SYCL_BASE/llvm/llvm

building with

make sycl-toolchain opencl-aot

and installing with

make deploy-sycl-toolchain deploy-opencl-aot

I find under $INSTALL_PATH:

bin/...

lib/clc
lib/libpi_opencl.so
lib/libsycl-cmath-fp64.o
lib/libsycl-cmath.o
lib/libsycl-complex-fp64.o
lib/libsycl-complex.o
lib/libsycl-fallback-cassert.spv
lib/libsycl-fallback-cmath-fp64.spv
lib/libsycl-fallback-cmath.spv
lib/libsycl-fallback-complex-fp64.spv
lib/libsycl-fallback-complex.spv
lib/libsycl-glibc.o
lib/libsycl.so
lib/libsycl.so-gdb.py

lib64/clang

I see few issues with this:

• libsycl.so does not honour LLVM_LIBDIR_SUFFIX
• libpi_opencl.so does not honour LLVM_LIBDIR_SUFFIX
• libpi_cuda.so is not installed by make deploy-sycl-toolchain
• clc does not honour LLVM_LIBDIR_SUFFIX

when building with -DBUILD_SHARED_LIBS=ON:

• libLLVM*.so are not installed by make deploy-sycl-toolchain
• libclang*.so are not installed by make deploy-sycl-toolchain

but it looks like BUILD_SHARED_LIBS=ON should not be used for building a distribution, so this might not be an issue.

[fwyzard]

These

• libsycl.so does not honour LLVM_LIBDIR_SUFFIX
• libpi_opencl.so does not honour LLVM_LIBDIR_SUFFIX
• clc does not honour LLVM_LIBDIR_SUFFIX

are fixed by #1261.

This

• libpi_cuda.so is not installed by make deploy-sycl-toolchain

is fixed by #1268.

[fwyzard]

These, when building with -DBUILD_SHARED_LIBS=ON:

• libLLVM*.so are not installed by make deploy-sycl-toolchain
• libclang*.so are not installed by make deploy-sycl-toolchain

are fixed by calling make install-llvm-libraries install-clang-libraries; would it make sense to add them as dependencies of deploy-sycl-toolchain ?