Skip to content

Commit

Permalink
[CI][NFC] Unify naming scheme for SYCL workflows. (#12568)
Browse files Browse the repository at this point in the history
All GitHub Actions workflows added by intel/llvm project are expected to
use following naming notation:

1. Name starts with `sycl` prefix.
2. Use dash `-` to separate words (instead of underscore `_`).

This patches fixes naming of workflows which do not follow this
notation.
  • Loading branch information
bader authored Jan 31, 2024
1 parent 85e461e commit 435845b
Show file tree
Hide file tree
Showing 19 changed files with 35 additions and 35 deletions.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,14 @@ on:
- 'devops/dependencies.json'
- 'devops/scripts/install_drivers.sh'
- 'devops/scripts/install_build_tools.sh'
- '.github/workflows/sycl_containers.yaml'
- '.github/workflows/sycl-containers.yaml'
pull_request:
paths:
- 'devops/containers/**'
- 'devops/dependencies.json'
- 'devops/scripts/install_drivers.sh'
- 'devops/scripts/install_build_tools.sh'
- '.github/workflows/sycl_containers.yaml'
- '.github/workflows/sycl-containers.yaml'

jobs:
base_image_ubuntu2204:
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
branches:
- sycl
paths:
- '.github/workflows/gh_pages.yml'
- '.github/workflows/sycl-docs.yml'
- 'clang/docs/**'
- 'sycl/doc/**'

Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
image: ghcr.io/intel/llvm/sycl_ubuntu2204_nightly:build
image_options: -u 1001 --gpus all --cap-add SYS_ADMIN
target_devices: ext_oneapi_cuda:gpu
uses: ./.github/workflows/sycl_linux_run_tests.yml
uses: ./.github/workflows/sycl-linux-run-tests.yml
with:
name: ${{ matrix.name }}
runner: ${{ matrix. runner }}
Expand All @@ -62,7 +62,7 @@ jobs:

aws_start:
name: AWS Start
uses: ./.github/workflows/sycl_aws.yml
uses: ./.github/workflows/sycl-aws.yml
secrets: inherit
with:
mode: start
Expand All @@ -71,7 +71,7 @@ jobs:
linux_e2e_on_nightly_aws:
name: '[AWS][CUDA] E2E on Nightly'
needs: [aws_start]
uses: ./.github/workflows/sycl_linux_run_tests.yml
uses: ./.github/workflows/sycl-linux-run-tests.yml
with:
name: CUDA
runner: '["aws-cuda_${{ github.run_id }}-${{ github.run_attempt }}"]'
Expand All @@ -86,7 +86,7 @@ jobs:
name: AWS Stop
needs: [aws_start, linux_e2e_on_nightly_aws]
if: always()
uses: ./.github/workflows/sycl_aws.yml
uses: ./.github/workflows/sycl-aws.yml
secrets: inherit
with:
mode: stop
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:

e2e-cuda:
needs: [aws-start]
uses: ./.github/workflows/sycl_linux_run_tests.yml
uses: ./.github/workflows/sycl-linux-run-tests.yml
with:
name: CUDA E2E
runner: '["aws_cuda-${{ github.event.workflow_run.id }}-${{ github.event.workflow_run.run_attempt }}"]'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@ on:
- 'clang/docs/**'
- '**.md'
- '**.rst'
- '.github/workflows/sycl_windows_*.yml'
- '.github/workflows/sycl_macos_*.yml'
- '.github/workflows/sycl-windows-*.yml'
- '.github/workflows/sycl-macos-*.yml'
- 'devops/containers/**'
- 'devops/actions/build_container/**'

Expand All @@ -30,12 +30,12 @@ concurrency:

jobs:
detect_changes:
uses: ./.github/workflows/sycl_detect_changes.yml
uses: ./.github/workflows/sycl-detect-changes.yml

build:
needs: [detect_changes]
if: always() && success()
uses: ./.github/workflows/sycl_linux_build.yml
uses: ./.github/workflows/sycl-linux-build.yml
with:
build_ref: ${{ github.sha }}
merge_ref: ''
Expand Down Expand Up @@ -75,7 +75,7 @@ jobs:
install_drivers: ${{ contains(needs.detect_changes.outputs.filters, 'drivers') }}
extra_lit_opts: --param matrix-xmx8=True --param gpu-intel-dg2=True
env: '{"LIT_FILTER":"Matrix/"}'
uses: ./.github/workflows/sycl_linux_run_tests.yml
uses: ./.github/workflows/sycl-linux-run-tests.yml
with:
name: ${{ matrix.name }}
runner: ${{ matrix. runner }}
Expand Down Expand Up @@ -111,7 +111,7 @@ jobs:
runner: '["Linux", "gen12"]'
- name: Perf tests on Intel Arc A-Series Graphics system
runner: '["Linux", "arc"]'
uses: ./.github/workflows/sycl_linux_run_tests.yml
uses: ./.github/workflows/sycl-linux-run-tests.yml
with:
name: ${{ matrix.name }}
runner: ${{ matrix. runner }}
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
jobs:
ubuntu2204_build:
if: github.repository == 'intel/llvm'
uses: ./.github/workflows/sycl_linux_build.yml
uses: ./.github/workflows/sycl-linux-build.yml
secrets: inherit
with:
build_cache_root: "/__w/"
Expand Down Expand Up @@ -59,7 +59,7 @@ jobs:
image: ghcr.io/intel/llvm/ubuntu2204_build:latest
image_options: -u 1001 --gpus all --cap-add SYS_ADMIN
target_devices: ext_oneapi_cuda:gpu
uses: ./.github/workflows/sycl_linux_run_tests.yml
uses: ./.github/workflows/sycl-linux-run-tests.yml
with:
name: ${{ matrix.name }}
runner: ${{ matrix.runner }}
Expand All @@ -74,7 +74,7 @@ jobs:
sycl_toolchain_decompress_command: ${{ needs.ubuntu2204_build.outputs.artifact_decompress_command }}

build-win:
uses: ./.github/workflows/sycl_windows_build.yml
uses: ./.github/workflows/sycl-windows-build.yml
if: github.repository == 'intel/llvm'
with:
retention-days: 90
Expand All @@ -89,7 +89,7 @@ jobs:
always()
&& !cancelled()
&& needs.build.outputs.build_conclusion == 'success'
uses: ./.github/workflows/sycl_windows_run_tests.yml
uses: ./.github/workflows/sycl-windows-run-tests.yml
with:
name: Intel GEN12 Graphics with Level Zero
runner: '["Windows","gen12"]'
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,18 +12,18 @@ on:
- sycl
- sycl-devops-pr/**
paths:
- .github/workflows/sycl_post_commit.yml
- .github/workflows/sycl_linux_build.yml
- .github/workflows/sycl_linux_run_tests.yml
- .github/workflows/sycl_macos_build_and_test.yml
- .github/workflows/sycl-post-commit.yml
- .github/workflows/sycl-linux-build.yml
- .github/workflows/sycl-linux-run-tests.yml
- .github/workflows/sycl-macos-build-and-test.yml
- ./devops/actions/cleanup
- ./devops/actions/cached_checkout

jobs:
build-lin:
name: Linux (Self build + shared libraries + no-assertions)
if: github.repository == 'intel/llvm'
uses: ./.github/workflows/sycl_linux_build.yml
uses: ./.github/workflows/sycl-linux-build.yml
with:
build_cache_root: "/__w/llvm"
build_cache_suffix: sprod_shared
Expand Down Expand Up @@ -63,7 +63,7 @@ jobs:
env: '{"LIT_FILTER":"PerformanceTests/"}'
extra_lit_opts: -a -j 1 --param enable-perf-tests=True
target_devices: all
uses: ./.github/workflows/sycl_linux_run_tests.yml
uses: ./.github/workflows/sycl-linux-run-tests.yml
with:
name: ${{ matrix.name }}
runner: ${{ matrix. runner }}
Expand All @@ -87,7 +87,7 @@ jobs:
always()
&& success()
&& github.repository == 'intel/llvm'
uses: ./.github/workflows/sycl_windows_build.yml
uses: ./.github/workflows/sycl-windows-build.yml

e2e-win:
needs: build-win
Expand All @@ -96,7 +96,7 @@ jobs:
always()
&& !cancelled()
&& needs.build-win.outputs.build_conclusion == 'success'
uses: ./.github/workflows/sycl_windows_run_tests.yml
uses: ./.github/workflows/sycl-windows-run-tests.yml
with:
name: Intel GEN12 Graphics with Level Zero
runner: '["Windows","gen12"]'
Expand All @@ -105,4 +105,4 @@ jobs:
macos_default:
name: macOS
if: github.repository == 'intel/llvm'
uses: ./.github/workflows/sycl_macos_build_and_test.yml
uses: ./.github/workflows/sycl-macos-build-and-test.yml
File renamed without changes.
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,9 @@ on:
- 'clang/docs/**'
- '**.md'
- '**.rst'
- '.github/workflows/sycl_linux_*.yml'
- '.github/workflows/sycl_precommit_aws.yml'
- '.github/workflows/sycl_macos_*.yml'
- '.github/workflows/sycl-linux-*.yml'
- '.github/workflows/sycl-precommit-aws.yml'
- '.github/workflows/sycl-macos-*.yml'
- 'devops/containers/**'
- 'devops/actions/build_container/**'

Expand All @@ -32,14 +32,14 @@ concurrency:

jobs:
detect_changes:
uses: ./.github/workflows/sycl_detect_changes.yml
uses: ./.github/workflows/sycl-detect-changes.yml

build:
needs: [detect_changes]
if: |
always() && success()
&& github.repository == 'intel/llvm'
uses: ./.github/workflows/sycl_windows_build.yml
uses: ./.github/workflows/sycl-windows-build.yml
with:
changes: ${{ needs.detect_changes.outputs.filters }}

Expand All @@ -50,7 +50,7 @@ jobs:
always()
&& !cancelled()
&& needs.build.outputs.build_conclusion == 'success'
uses: ./.github/workflows/sycl_windows_run_tests.yml
uses: ./.github/workflows/sycl-windows-run-tests.yml
with:
name: Intel GEN12 Graphics with Level Zero
runner: '["Windows","gen12"]'
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ For general contribution process see [CONTRIBUTING.md](./CONTRIBUTING.md)

[![oneAPI logo](https://spec.oneapi.io/oneapi-logo-white-scaled.jpg)](https://www.oneapi.io/)

[![SYCL Post Commit](https://github.com/intel/llvm/actions/workflows/sycl_post_commit.yml/badge.svg?branch=sycl)](https://github.com/intel/llvm/actions/workflows/sycl_post_commit.yml)
[![Generate Doxygen documentation](https://github.com/intel/llvm/actions/workflows/gh_pages.yml/badge.svg?branch=sycl)](https://github.com/intel/llvm/actions/workflows/gh_pages.yml)
[![SYCL Post Commit](https://github.com/intel/llvm/actions/workflows/sycl-post-commit.yml/badge.svg?branch=sycl)](https://github.com/intel/llvm/actions/workflows/sycl-post-commit.yml)
[![Generate Doxygen documentation](https://github.com/intel/llvm/actions/workflows/sycl-docs.yml/badge.svg?branch=sycl)](https://github.com/intel/llvm/actions/workflows/sycl-docs.yml)

The DPC++ is a LLVM-based compiler project that implements compiler and runtime
support for the SYCL\* language. The project is hosted in the
Expand Down

1 comment on commit 435845b

@aelovikov-intel
Copy link
Contributor

@aelovikov-intel aelovikov-intel commented on 435845b Feb 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-hosted CUDA runner failures in Nightly:

Failed Tests (1):
  SYCL :: Assert/assert_in_multiple_tus.cpp
FAIL: SYCL :: Assert/assert_in_multiple_tus.cpp (37 of 1857)
******************** TEST 'SYCL :: Assert/assert_in_multiple_tus.cpp' FAILED ********************
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 9
/__w/llvm/llvm/toolchain/bin//clang++   -fsycl -fsycl-targets=nvptx64-nvidia-cuda /__w/llvm/llvm/llvm/sycl/test-e2e/Assert/assert_in_multiple_tus.cpp -DSYCL_FALLBACK_ASSERT=1 -I /__w/llvm/llvm/llvm/sycl/test-e2e/Assert/Inputs /__w/llvm/llvm/llvm/sycl/test-e2e/Assert/Inputs/kernels_in_file2.cpp -o /__w/llvm/llvm/build-e2e/Assert/Output/assert_in_multiple_tus.cpp.tmp.out
# executed command: /__w/llvm/llvm/toolchain/bin//clang++ -fsycl -fsycl-targets=nvptx64-nvidia-cuda /__w/llvm/llvm/llvm/sycl/test-e2e/Assert/assert_in_multiple_tus.cpp -DSYCL_FALLBACK_ASSERT=1 -I /__w/llvm/llvm/llvm/sycl/test-e2e/Assert/Inputs /__w/llvm/llvm/llvm/sycl/test-e2e/Assert/Inputs/kernels_in_file2.cpp -o /__w/llvm/llvm/build-e2e/Assert/Output/assert_in_multiple_tus.cpp.tmp.out
# note: command had no output on stdout or stderr
# RUN: at line 10
env SYCL_PI_CUDA_ENABLE_IMAGE_SUPPORT=1 ONEAPI_DEVICE_SELECTOR=cuda:gpu  /__w/llvm/llvm/build-e2e/Assert/Output/assert_in_multiple_tus.cpp.tmp.out &> /__w/llvm/llvm/build-e2e/Assert/Output/assert_in_multiple_tus.cpp.tmp.txt ; /__w/llvm/llvm/toolchain/bin/FileCheck /__w/llvm/llvm/llvm/sycl/test-e2e/Assert/assert_in_multiple_tus.cpp --input-file /__w/llvm/llvm/build-e2e/Assert/Output/assert_in_multiple_tus.cpp.tmp.txt
# executed command: env SYCL_PI_CUDA_ENABLE_IMAGE_SUPPORT=1 ONEAPI_DEVICE_SELECTOR=cuda:gpu /__w/llvm/llvm/build-e2e/Assert/Output/assert_in_multiple_tus.cpp.tmp.out
# .---redirected output from '/__w/llvm/llvm/build-e2e/Assert/Output/assert_in_multiple_tus.cpp.tmp.txt'
# | 
# | UR CUDA ERROR:
# | 	Value:           710
# | 	Name:            CUDA_ERROR_ASSERT
# | 	Description:     device-side assert triggered
# | 	Function:        buildProgram
# | 	Source Location: /__w/llvm/llvm/build/_deps/unified-runtime-src/source/adapters/cuda/program.cpp:149
# | 
# | terminate called after throwing an instance of 'sycl::_V1::compile_program_error'
# |   what():  The program was built for 1 devices
# | Build program log for 'NVIDIA GeForce RTX 3090':
# |  -999 (Unknown PI error)
# `-----------------------------
# note: command had no output on stdout or stderr
# error: command failed with exit status: -6
# executed command: /__w/llvm/llvm/toolchain/bin/FileCheck /__w/llvm/llvm/llvm/sycl/test-e2e/Assert/assert_in_multiple_tus.cpp --input-file /__w/llvm/llvm/build-e2e/Assert/Output/assert_in_multiple_tus.cpp.tmp.txt
# .---command stderr------------
# | /__w/llvm/llvm/llvm/sycl/test-e2e/Assert/assert_in_multiple_tus.cpp:15:11: error: CHECK: expected string not found in input
# | // CHECK: {{.*}}kernels_in_file2.cpp:15: int calculus(int): {{global id: \[5|block: \[1}},0,0], {{local id|thread}}: [1,0,0]
# |           ^
# | /__w/llvm/llvm/build-e2e/Assert/Output/assert_in_multiple_tus.cpp.tmp.txt:1:1: note: scanning from here
# | 
# | ^
# | 
# | Input file: /__w/llvm/llvm/build-e2e/Assert/Output/assert_in_multiple_tus.cpp.tmp.txt
# | Check file: /__w/llvm/llvm/llvm/sycl/test-e2e/Assert/assert_in_multiple_tus.cpp
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |           1:  
# | check:15     X error: no match found
# |           2: UR CUDA ERROR: 
# | check:15     ~~~~~~~~~~~~~~~
# |           3:  Value: 710 
# | check:15     ~~~~~~~~~~~~
# |           4:  Name: CUDA_ERROR_ASSERT 
# | check:15     ~~~~~~~~~~~~~~~~~~~~~~~~~
# |           5:  Description: device-side assert triggered 
# | check:15     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |           6:  Function: buildProgram 
# | check:15     ~~~~~~~~~~~~~~~~~~~~~~~~
# |           .
# |           .
# |           .
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

Seems to be tracked in #8832.

Please sign in to comment.