[SYCL][ESIMD][EMU] Marking ESIMD kernels for esimd_emulator backend #751

dongkyunahn-intel · 2022-01-18T22:35:24Z

This PR is to mark ESIMD kernels for esimd_emulator backend with UNSUPPORTED or XFAIL for future feature bring-up and debug.

- 'vadd_1d' and 'sycl_esimd_mix' are duplicated to 'esimd_check_vc_codegen.cpp' and 'sycl_esimd_mix_check_build_opts.cpp' so that original kernels can run with esimd_emulator without 'CHECK' commands and duplicated kernels can run with opencl/level_zero backends with 'CHECK'

dongkyunahn-intel · 2022-01-18T23:15:58Z

This PR will be merged after ESIMD_EMULATOR support is enabled by default in intel/llvm - intel/llvm#5058.

SYCL/ESIMD/esimd_check_vc_codegen.cpp

SYCL/ESIMD/sycl_esimd_mix.cpp

SYCL/ESIMD/sycl_esimd_mix_check_build_opts.cpp

SYCL/lit.cfg.py

This reverts commit c5b6567.

- With 'UNSUPPORTED: esimd_emulator' and comment

SYCL/ESIMD/esimd_check_vc_codegen.cpp

kbobrovs · 2022-01-20T04:41:30Z

SYCL/ESIMD/esimd_check_vc_codegen.cpp

+
+  int err_cnt = 0;
+
+  for (unsigned i = 0; i < Size; ++i) {
+    if (A[i] + B[i] != C[i]) {
+      if (++err_cnt < 10) {
+        std::cout << "failed at index " << i << ", " << C[i] << " != " << A[i]
+                  << " + " << B[i] << "\n";
+      }
+    }
+  }
+  if (err_cnt > 0) {
+    std::cout << "  pass rate: "
+              << ((float)(Size - err_cnt) / (float)Size) * 100.0f << "% ("
+              << (Size - err_cnt) << "/" << Size << ")\n";
+  }
+
+  delete[] A;
+  delete[] B;
+  delete[] C;
+
+  std::cout << (err_cnt > 0 ? "FAILED\n" : "Passed\n");
+  return err_cnt > 0 ? 1 : 0;


Suggested change

int err_cnt = 0;

for (unsigned i = 0; i < Size; ++i) {

if (A[i] + B[i] != C[i]) {

if (++err_cnt < 10) {

std::cout << "failed at index " << i << ", " << C[i] << " != " << A[i]

<< " + " << B[i] << "\n";

}

}

}

if (err_cnt > 0) {

std::cout << " pass rate: "

<< ((float)(Size - err_cnt) / (float)Size) * 100.0f << "% ("

<< (Size - err_cnt) << "/" << Size << ")\n";

}

delete[] A;

delete[] B;

delete[] C;

std::cout << (err_cnt > 0 ? "FAILED\n" : "Passed\n");

return err_cnt > 0 ? 1 : 0;

return 0;

@kbobrovs , esimd_check_vc_codegen.cpp fails after being simplified with single_task - for both open_cl and level_zero. Maybe it has to be reverted.

[2022-01-27T05:52:29.296Z] /netbatch/donb02499_00/runDir/jenkins-dir/workspace/LLVM-Test-Suite-CI-TMP/LLVM-Test-Suite-CI-Linux/llvm-test-suite/SYCL/ESIMD/esimd_check_vc_codegen.cpp:41:11: error: CHECK: expected string not found in input [2022-01-27T05:52:29.296Z] // CHECK: <const char *>: {{.*}}-vc-codegen [2022-01-27T05:52:29.296Z] ^ [2022-01-27T05:52:29.296Z] <stdin>:415:2: note: scanning from here [2022-01-27T05:52:29.296Z] <unknown> : 0x7056b0 [2022-01-27T05:52:29.296Z] ^ [2022-01-27T05:52:29.296Z] <stdin>:418:2: note: possible intended match here [2022-01-27T05:52:29.296Z] <const char *>: [2022-01-27T05:52:29.296Z] ^ [2022-01-27T05:52:29.296Z]

Co-authored-by: kbobrovs <Konstantin.S.Bobrovsky@intel.com>

… invoke_esimd_emulator_check_in

SYCL/ESIMD/esimd_check_vc_codegen.cpp

SYCL/ESIMD/vadd_1d.cpp

- Unimplemented features - Outdated memory intrinsic implementations Matrix size limitation - matrix_transpose_glb.cpp

- Missing XFAIL markup replacing UNSUPPORTED

kbobrovs · 2022-01-27T06:00:46Z

SYCL/ESIMD/histogram_256_slm_spec_2020.cpp

@@ -1,6 +1,7 @@
 // TODO enable on Windows
 // REQUIRES: linux && gpu
 // UNSUPPORTED: cuda || hip
+// XFAIL: esimd_emulator


kbobrovs · 2022-01-27T06:01:03Z

SYCL/ESIMD/mandelbrot/mandelbrot_spec.cpp

@@ -9,6 +9,7 @@
 // TODO enable on Windows
 // REQUIRES: linux && gpu
 // UNSUPPORTED: cuda || hip
+// XFAIL: esimd_emulator


kbobrovs · 2022-01-27T06:02:03Z

SYCL/ESIMD/regression/complex-lib-lin.cpp

@@ -7,6 +7,7 @@
 //
 // REQUIRES: linux,gpu
 // UNSUPPORTED: cuda || hip
+// XFAIL: esimd_emulator


kbobrovs · 2022-01-27T06:02:22Z

SYCL/ESIMD/regression/globals.cpp

@@ -1,5 +1,7 @@
 // REQUIRES: gpu
 // UNSUPPORTED: cuda || hip
+// Sub-group is not supported


Suggested change

// Sub-group is not supported

// TODO Sub-group is not supported

kbobrovs · 2022-01-27T06:02:38Z

SYCL/ESIMD/spec_const/spec_const_bool.cpp

@@ -9,6 +9,7 @@
 // RUN: %clangxx -fsycl -I%S/.. %s -o %t.out
 // RUN: %GPU_RUN_PLACEHOLDER %t.out
 // UNSUPPORTED: cuda || hip
+// XFAIL: esimd_emulator


TODO? here and other places. We should eventually support spec constants in the emulator.

Like I showed in messenger, online_compiler check fails for all spec* tests - even if it is not required. To whom should I ask about this issue? (Someone in SYCL_RT?)

- as 'esimd_emulator' is substring of 'ext_intel_esimd_emulator'

- Host backend and esimd_emulator backend share same header file for memory intrinsic support - memory_intrin.h - This sharing prevents the same header file from supporting both backend types as some intrinsic support (e.g. __esimd_media_ld/st) are different and they are chosen during kernel compilation - while backends are chosen during kernel execution - Therefore, tests invoking those implementations must not contain 'HOST_RUN_PLACEHOLDER' as the implementations require esimd_emulator backend

- As 'CHECK' fails for 'piProgramBuild' PI_API call

… invoke_esimd_emulator_check_in

dongkyunahn-intel · 2022-02-02T19:01:01Z

esimd_check_vc_codegen.cpp will be revised to minimized test as @kbobrovs suggested in a separate PR.

kbobrovs

LGTM, but please address the vc_code_gen test comment at your earliest convenience.

… invoke_esimd_emulator_check_in

- For tests failed due to unimplemented features such as 'half' type

This reverts commit 697e3bd.

…ator'" This reverts commit 092f7c1.

…ntel#751) - 'vadd_1d' and 'sycl_esimd_mix' are duplicated to 'esimd_check_vc_codegen.cpp' and 'sycl_esimd_mix_check_build_opts.cpp' so that original kernels can run with esimd_emulator without 'CHECK' commands and duplicated kernels can run with opencl/level_zero backends with 'CHECK' - Add XFAIL/UNSUPPORTED markup for - Unimplemented features - Outdated memory intrinsic implementations - Reduce workset in matrix_transpose_glb.cpp when running on esimd_emulator - Removing HOST_RUN_PLACEHOLDER for ESIMD Kernels

…ntel/llvm-test-suite#751) - 'vadd_1d' and 'sycl_esimd_mix' are duplicated to 'esimd_check_vc_codegen.cpp' and 'sycl_esimd_mix_check_build_opts.cpp' so that original kernels can run with esimd_emulator without 'CHECK' commands and duplicated kernels can run with opencl/level_zero backends with 'CHECK' - Add XFAIL/UNSUPPORTED markup for - Unimplemented features - Outdated memory intrinsic implementations - Reduce workset in matrix_transpose_glb.cpp when running on esimd_emulator - Removing HOST_RUN_PLACEHOLDER for ESIMD Kernels

dongkyunahn-intel added 2 commits January 18, 2022 11:09

Adding 'esimd_emualtor' as supported SYCL backend

c5b6567

dongkyunahn-intel requested review from kbobrovs and vladimirlaz January 18, 2022 22:35

dongkyunahn-intel requested review from a team as code owners January 18, 2022 22:35

dongkyunahn-intel requested a review from bader January 18, 2022 22:36

kbobrovs suggested changes Jan 18, 2022

View reviewed changes

SYCL/ESIMD/esimd_check_vc_codegen.cpp Show resolved Hide resolved

SYCL/ESIMD/sycl_esimd_mix.cpp Outdated Show resolved Hide resolved

SYCL/ESIMD/sycl_esimd_mix_check_build_opts.cpp Outdated Show resolved Hide resolved

vladimirlaz reviewed Jan 19, 2022

View reviewed changes

SYCL/lit.cfg.py Outdated Show resolved Hide resolved

dongkyunahn-intel added 3 commits January 19, 2022 10:34

Revert "Adding 'esimd_emualtor' as supported SYCL backend"

68c4c1f

This reverts commit c5b6567.

Reverting changes in 'SYCL/ESIMD/sycl_esimd_mix.cpp'

08c0158

- With 'UNSUPPORTED: esimd_emulator' and comment

Fixing typo in comment for SYCL/ESIMD/vadd_1d.cpp

1febb1b

dongkyunahn-intel changed the title ~~Invoke esimd emulator check in~~ [SYCL][ESIMD][EMU] Marking ESIMD kernels for esimd_emulator backend Jan 20, 2022

dongkyunahn-intel mentioned this pull request Jan 20, 2022

[SYCL] Update LIT to support the latest BEs #752

Merged

kbobrovs reviewed Jan 20, 2022

View reviewed changes

dongkyunahn-intel and others added 4 commits January 25, 2022 14:23

Apply suggestions from code review

647368d

Co-authored-by: kbobrovs <Konstantin.S.Bobrovsky@intel.com>

Marking ESIMD kernels 'UNSUPPORTED' for esimd_emulator backend

bbc31d9

clang-format error fix

18df6bb

Merge branch 'intel' of https://github.com/intel/llvm-test-suite into…

d61e3be

… invoke_esimd_emulator_check_in

kbobrovs reviewed Jan 26, 2022

View reviewed changes

SYCL/ESIMD/esimd_check_vc_codegen.cpp Outdated Show resolved Hide resolved

kbobrovs reviewed Jan 26, 2022

View reviewed changes

SYCL/ESIMD/esimd_check_vc_codegen.cpp Show resolved Hide resolved

kbobrovs reviewed Jan 26, 2022

View reviewed changes

SYCL/ESIMD/vadd_1d.cpp Outdated Show resolved Hide resolved

kbobrovs reviewed Jan 26, 2022

View reviewed changes

SYCL/ESIMD/vadd_1d.cpp Outdated Show resolved Hide resolved

dongkyunahn-intel added 2 commits January 26, 2022 15:32

XFAIL markups replacing UNSUPPORTED

b5bb143

- Unimplemented features - Outdated memory intrinsic implementations Matrix size limitation - matrix_transpose_glb.cpp

clang-format fix

c213138

- Missing XFAIL markup replacing UNSUPPORTED

dongkyunahn-intel requested a review from kbobrovs January 27, 2022 03:03

kbobrovs reviewed Jan 27, 2022

View reviewed changes

kbobrovs previously approved these changes Jan 27, 2022

View reviewed changes

dongkyunahn-intel added 3 commits January 27, 2022 08:49

'esimd_emulator' as deprecated name for 'ext_intel_esimd_emulator'

092f7c1

- as 'esimd_emulator' is substring of 'ext_intel_esimd_emulator'

Missing TODO comments for esimd_emulator support markup

cb09441

Adding dummy codes to invoke piProgramBuild for vc_codegen

c53aa85

dongkyunahn-intel dismissed kbobrovs’s stale review via c53aa85 January 27, 2022 21:47

dongkyunahn-intel added 2 commits January 28, 2022 12:21

Recovering 'esimd_check_vc_codegen.cpp' to its initial import version

bbdb607

- As 'CHECK' fails for 'piProgramBuild' PI_API call

dongkyunahn-intel requested review from vladimirlaz and kbobrovs January 28, 2022 20:43

Merge branch 'intel' of https://github.com/intel/llvm-test-suite into…

a4c51cc

… invoke_esimd_emulator_check_in

bader removed their request for review February 2, 2022 10:10

kbobrovs previously approved these changes Feb 2, 2022

View reviewed changes

dongkyunahn-intel added 5 commits February 4, 2022 14:46

Merge branch 'intel' of https://github.com/intel/llvm-test-suite into…

e70bab1

… invoke_esimd_emulator_check_in

Changing 'UNSUPPORTED' to 'XFAIL' for esimd_emulator backend

a97e08f

- For tests failed due to unimplemented features such as 'half' type

Marking 'XFAIL' for newly added tests

b6601cf

Revert "Removing HOST_RUN_PLACEHOLDER for ESIMD Kernels"

6580013

This reverts commit 697e3bd.

Revert "'esimd_emulator' as deprecated name for 'ext_intel_esimd_emul…

4c955cf

…ator'" This reverts commit 092f7c1.

dongkyunahn-intel dismissed kbobrovs’s stale review via 4c955cf February 5, 2022 03:52

vladimirlaz approved these changes Feb 7, 2022

View reviewed changes

dongkyunahn-intel requested a review from kbobrovs February 7, 2022 17:52

kbobrovs approved these changes Feb 8, 2022

View reviewed changes

kbobrovs merged commit d98407d into intel:intel Feb 8, 2022

	// Sub-group is not supported
	// TODO Sub-group is not supported

[SYCL][ESIMD][EMU] Marking ESIMD kernels for esimd_emulator backend #751

[SYCL][ESIMD][EMU] Marking ESIMD kernels for esimd_emulator backend #751

Uh oh!

Conversation

dongkyunahn-intel commented Jan 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dongkyunahn-intel commented Jan 18, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kbobrovs Jan 20, 2022

Choose a reason for hiding this comment

Uh oh!

dongkyunahn-intel Jan 27, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kbobrovs Jan 27, 2022

Choose a reason for hiding this comment

Uh oh!

kbobrovs Jan 27, 2022

Choose a reason for hiding this comment

Uh oh!

kbobrovs Jan 27, 2022

Choose a reason for hiding this comment

Uh oh!

kbobrovs Jan 27, 2022

Choose a reason for hiding this comment

Uh oh!

kbobrovs Jan 27, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dongkyunahn-intel Jan 27, 2022

Choose a reason for hiding this comment

Uh oh!

dongkyunahn-intel commented Feb 2, 2022

Uh oh!

kbobrovs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dongkyunahn-intel commented Jan 18, 2022 •

edited

Loading

kbobrovs Jan 27, 2022 •

edited

Loading