Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][ESIMD][EMU] Enabling ESIMD_EMULATOR #582

Closed
wants to merge 7 commits into from
Closed

[SYCL][ESIMD][EMU] Enabling ESIMD_EMULATOR #582

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e190ba7
[SYCL][ESIMD][EMU] Enabling ESIMD_EMULATOR
dongkyunahn-intel Oct 25, 2021
4f0199b
clang-format fix
dongkyunahn-intel Nov 24, 2021
745ea37
Registering esimd_emulator in lit config
dongkyunahn-intel Nov 29, 2021
103ec5a
Marking 'UNSUPPORTED' for failing Non-ESIMD kernels
dongkyunahn-intel Dec 11, 2021
39d4f3a
Marking ESIMD kernels with known failures as XFAIL:esimd_emulator
dongkyunahn-intel Dec 13, 2021
786a18a
Duplicating ESIMD samples for esimd_emulator
dongkyunahn-intel Dec 13, 2021
e7a02ee
Resolving timeouts
dongkyunahn-intel Dec 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion SYCL/Plugin/sycl-ls.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// RUN: sycl-ls --verbose | grep "Device \[" | wc -l >%t.verbose.out
// RUN: sycl-ls | wc -l >%t.concise.out
// RUN: sycl-ls | grep "^\[[a-z0-9_]*:[a-z]*:[0-9]*\]\ " | wc -l >%t.concise.out
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the weird filter doing and can we please avoid it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the ESIMD_EMULATOR support, sycl-ls application prints out like below.

EMU: *** Warning no kernel information query method is supported in current build.
EMU: [kernel support,critical] kernel data query via debug data is not supported in current build.
EMU: [kernel support] *** Warning kernel  arguments data is not found.
[ext_intel_esimd_emulator:gpu:0] Intel(R) ESIMD_EMULATOR/GPU, ESIMD_EMULATOR 1.0.7-CM_EMU [0.1.0]
[host:host:0] SYCL host platform, SYCL host device 1.2 [1.2]

CM_EMU library supporting ESIMD_EMULATOR could print out extra info for debugging - like first three lines of above. It cannot be controlled from SYCL as it is from CM_EMU and CM_EMU prints out them by default. This change is to filter out such extra info for comparison between outputs from 'verbose' output and 'concise' output.

There is ongoing internal discussion for controlling printouts from CM_EMU. As soon as it is decided how these printouts are controlled and applied in CM_EMU, I'm going to remove this filtering.

// RUN: diff %t.verbose.out %t.concise.out

//==---- sycl-ls.cpp - SYCL test for consistency of sycl-ls output ---------==//
Expand Down
5 changes: 3 additions & 2 deletions SYCL/SpecConstants/2020/host_apis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,9 @@ const static sycl::specialization_id<TestStruct2> SpecConst5{
int main() {
sycl::queue Q;

// No support for host device so far
if (Q.is_host())
// No support for host device and esimd_emulator so far
if (Q.is_host() ||
Q.get_backend() == cl::sycl::backend::ext_intel_esimd_emulator)
return 0;

// The code is needed to just have device images in the executable
Expand Down