This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Add test for AllocaCommand cleanup #466
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanovvlad
reviewed
Sep 19, 2021
| } | ||
|
|
||
| auto policy = oneapi::dpl::execution::make_device_policy(q); | ||
| auto w_begin = oneapi::dpl::begin(w_buf); |
There was a problem hiding this comment.
I believe it's better to avoid dependencies on non SYCL APIs in these tests.
Tagging @vladimirlaz
There was a problem hiding this comment.
It is better to avoid extra dependencies in these tests? Is it possible to remove the use of DPL?
There was a problem hiding this comment.
Added is the reproducer for the sporadic segfaults fixed in intel/llvm#4573. I agree that having dependencies to other moving components in SYCL tests is not a good idea, however this was the only reproducer I have at hand. I'll check to see if the issue reproduces even after removing the DPL dependencies.
|
Closing this PR. intel/llvm#4573 adds in a unit test for the failing scenario fixed there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.