This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[ESIMD] Enable math functions: cos,sin,exp,log #312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DenisBakhvalov
commented
Jun 4, 2021
| Pass &= test<MathOp::sin, VL>(Q, "sin", InitDataFuncWide{}); | ||
| Pass &= test<MathOp::cos, VL>(Q, "cos", InitDataFuncWide{}); | ||
| Pass &= test<MathOp::exp, VL>(Q, "exp"); | ||
| Pass &= test<MathOp::exp, VL>(Q, "exp", InitDataInRange0_5{}); |
There was a problem hiding this comment.
The precision of FP operations gets lower towards bigger numbers, that's why we use the smaller value range.
kbobrovs
reviewed
Jun 25, 2021
kbobrovs
previously approved these changes
Jun 25, 2021
|
We need to wait until the next GPU driver uplift happens. The test will pass starting from the 21.24.20098 version. |
|
The 21.24.20098 driver is going to be used since 02/30/2021 nightly |
|
@DenisBakhvalov it looks like the modified test is failing on Windows. Could you please address the issue? |
|
@kbobrovs, please review/approve. |
kbobrovs
approved these changes
Jul 20, 2021
smaslov-intel
pushed a commit
to smaslov-intel/llvm-test-suite
that referenced
this pull request
Aug 12, 2021
* [ESIMD] Enable math functions: cos,sin,exp,log
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Apr 12, 2022
CMPLRLLVM-29952: Specify an absolute path to clang for SYCL testing
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…#312) * [ESIMD] Enable math functions: cos,sin,exp,log
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.