-
Notifications
You must be signed in to change notification settings - Fork 131
[SYCL] Remove -std=c++14 from tests as new SYCL 2020 features require C++17 #202
[SYCL] Remove -std=c++14 from tests as new SYCL 2020 features require C++17 #202
Conversation
This patch removes -std=c++14 from SYCL tests because some of the SYCL 2020 features require C++17 features and syntax
Failures in Jenkins/pre-ci-linux are not related to this patch:
|
b6bc4a0
Failures in Jenkins/pre-ci-windows is not related to the changes in the patch. They can be flaky. With previous run of Jenkins/pre-ci-windows, test |
@vladimirlaz , @bader , can you please merge this PR? |
Please, address pre-commit checks failure to unblock the merge. |
Opened intel/llvm#8814 for SYCL/Sampler tests. |
7a0912c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please revert changes in Sampler tests:
@cperkinsintel implemented some WA there:
#207
#196
Didn't revert Sampler/normalized-clamp-nearest.cpp because there were no fixes for this test. |
… C++17 (intel/llvm-test-suite#202) This patch removes -std=c++14 from SYCL tests because some of the SYCL 2020 features require C++17 features and syntax
This patch removes -std=c++14 from SYCL tests because some of the SYCL
2020 features require C++17 features and syntax