Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Remove -std=c++14 from tests as new SYCL 2020 features require C++17 #202

Conversation

dm-vodopyanov
Copy link

This patch removes -std=c++14 from SYCL tests because some of the SYCL
2020 features require C++17 features and syntax

This patch removes -std=c++14 from SYCL tests because some of the SYCL
2020 features require C++17 features and syntax
DenisBakhvalov
DenisBakhvalov previously approved these changes Mar 26, 2021
kbobrovs
kbobrovs previously approved these changes Mar 27, 2021
@dm-vodopyanov dm-vodopyanov changed the title [SYCL] Remove -std=c++14 from tests as new SYCL 2020 requires C++17 [SYCL] Remove -std=c++14 from tests as new SYCL 2020 features require C++17 Mar 27, 2021
AlexeySachkov
AlexeySachkov previously approved these changes Mar 29, 2021
@dm-vodopyanov
Copy link
Author

Failures in Jenkins/pre-ci-linux are not related to this patch:

[2021-03-26T19:54:56.078Z] [proxychains] DLL init: proxychains-ng 4.14-git-34-gfa9644d
[2021-03-26T19:54:56.078Z] Abort was called at 87 line in file:
[2021-03-26T19:54:56.078Z] ../neo/shared/source/os_interface/linux/drm_buffer_object.cpp

@dm-vodopyanov
Copy link
Author

Failures in Jenkins/pre-ci-windows is not related to the changes in the patch. They can be flaky. With previous run of Jenkins/pre-ci-windows, test regression/kernel_unnamed.cpp failed, now - Sampler/unnormalized-clampedge-nearest.cpp.
@DenisBakhvalov , @kbobrovs and @AlexeySachkov , can you please re-approve?

AlexeySachkov
AlexeySachkov previously approved these changes Mar 30, 2021
DenisBakhvalov
DenisBakhvalov previously approved these changes Mar 30, 2021
@dm-vodopyanov
Copy link
Author

@vladimirlaz , @bader , can you please merge this PR?

@bader
Copy link

bader commented Mar 30, 2021

Failures in Jenkins/pre-ci-windows is not related to the changes in the patch. They can be flaky. With previous run of Jenkins/pre-ci-windows, test regression/kernel_unnamed.cpp failed, now - Sampler/unnormalized-clampedge-nearest.cpp.
@DenisBakhvalov , @kbobrovs and @AlexeySachkov , can you please re-approve?

Please, address pre-commit checks failure to unblock the merge.
Even though the failure is not related to the patch, you still have to pass all checks.
If you are not able to fix it, you can file an issue to someone else and disable the test in pre-commit validation.

@DenisBakhvalov
Copy link

Opened intel/llvm#8814 for SYCL/Sampler tests.

kbobrovs
kbobrovs previously approved these changes Mar 30, 2021
Copy link

@kbobrovs kbobrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@vladimirlaz vladimirlaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please revert changes in Sampler tests:
@cperkinsintel implemented some WA there:
#207
#196

@dm-vodopyanov
Copy link
Author

Didn't revert Sampler/normalized-clamp-nearest.cpp because there were no fixes for this test.

@vladimirlaz vladimirlaz merged commit f34dd22 into intel:intel Mar 31, 2021
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
… C++17 (intel/llvm-test-suite#202)

This patch removes -std=c++14 from SYCL tests because some of the SYCL
2020 features require C++17 features and syntax
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants