Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL][Matrix] Adding test cases for the joint_matrix_apply() and fixing namespace for get_wi_data() #1636

Merged
merged 20 commits into from
Mar 21, 2023

Conversation

arnamoy10
Copy link

@arnamoy10 arnamoy10 commented Mar 7, 2023

for both ATS-M and PVC.

Regarding the namespace change, the tests will pass once this PR gets approved.

@dkhaldi
Copy link

dkhaldi commented Mar 7, 2023

Can you also modify the tests that have get_wi_data to use the Intel namespace?

@arnamoy10 arnamoy10 changed the title [SYCL][Matrix] Adding test cases for the joint_matrix_apply() interface [SYCL][Matrix] Adding test cases for the joint_matrix_apply() and fixing namespace for get_wi_data() Mar 9, 2023
@arnamoy10
Copy link
Author

Can you also modify the tests that have get_wi_data to use the Intel namespace?

Done

Copy link

@dkhaldi dkhaldi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnamoy10
Copy link
Author

@intel/llvm-gatekeepers Can you please help merge this patch?

@steffenlarsen steffenlarsen merged commit 1cf4f4c into intel Mar 21, 2023
@arnamoy10 arnamoy10 deleted the elemwise_jm_apply branch March 21, 2023 18:28
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
…ing namespace for get_wi_data() (intel/llvm-test-suite#1636)

for both ATS-M and PVC.

Regarding the namespace change, the tests will pass once [this PR](intel#8417) gets approved.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants