This repository was archived by the owner on Mar 28, 2023. It is now read-only.
forked from llvm/llvm-test-suite
-
Notifications
You must be signed in to change notification settings - Fork 130
[SYCL][Matrix] Adding test cases for the joint_matrix_apply() and fixing namespace for get_wi_data() #1636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for both ATS-M and PVC.
dkhaldi
suggested changes
Mar 7, 2023
Can you also modify the tests that have get_wi_data to use the Intel namespace? |
Done |
dkhaldi
suggested changes
Mar 14, 2023
dkhaldi
reviewed
Mar 16, 2023
aelovikov-intel
approved these changes
Mar 16, 2023
dkhaldi
approved these changes
Mar 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@intel/llvm-gatekeepers Can you please help merge this patch? |
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…ing namespace for get_wi_data() (intel/llvm-test-suite#1636) for both ATS-M and PVC. Regarding the namespace change, the tests will pass once [this PR](intel#8417) gets approved.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for both ATS-M and PVC.
Regarding the namespace change, the tests will pass once this PR gets approved.