Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Disable sort over sub-group for CUDA and HIP BEs #1396

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions SYCL/GroupAlgorithm/SYCL2020/sort.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
//
// TODO: Test global memory for temporary storage
// TODO: Consider using USM instead of buffers
//
// TODO: Add support for sorting over workgroup for CUDA and HIP BE

#include <sycl/sycl.hpp>

Expand Down Expand Up @@ -312,12 +312,18 @@ template <class T> void RunOverType(sycl::queue &Q, size_t DataSize) {
RunSortOVerGroup<UseGroupT::WorkGroup, 1>(Q, Data, Comparator);
RunSortOVerGroup<UseGroupT::WorkGroup, 2>(Q, Data, Comparator);

RunSortOVerGroup<UseGroupT::SubGroup, 1>(Q, Data, Comparator);
RunSortOVerGroup<UseGroupT::SubGroup, 2>(Q, Data, Comparator);

RunJointSort<UseGroupT::WorkGroup, 1>(Q, Data, Comparator);
RunJointSort<UseGroupT::WorkGroup, 2>(Q, Data, Comparator);

if (Q.get_backend() == sycl::backend::ext_oneapi_cuda ||
Q.get_backend() == sycl::backend::ext_oneapi_hip) {
std::cout << "Note! Skipping sub group testing on CUDA BE" << std::endl;
return;
}

RunSortOVerGroup<UseGroupT::SubGroup, 1>(Q, Data, Comparator);
RunSortOVerGroup<UseGroupT::SubGroup, 2>(Q, Data, Comparator);

RunJointSort<UseGroupT::SubGroup, 1>(Q, Data, Comparator);
RunJointSort<UseGroupT::SubGroup, 2>(Q, Data, Comparator);
};
Expand Down