-
Notifications
You must be signed in to change notification settings - Fork 130
[SYCL] Add test for sorting over sub-group #1380
[SYCL] Add test for sorting over sub-group #1380
Conversation
While extending the original test did some refactoring: 1. Reduced types it tests 2. Test only 1 and 2 dimensions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Big thanks for making such changes! I very appreciate it!
Any plans to test 3 dimensions?
LGTM. Make sure that CI is passed |
The fail KernelAndProgram/kernel-bundle-merge-options-env.cpp is unrelated. Merging. |
@romanovvlad this is failing on CUDA and HIP, they don't support |
Cannot find an API for querying sub-groups size for a given kernel with a given work-group size. Am I missing something? |
I don't think there's a way to query for that, I think either we need to not specify it, let the device pick for us and use Or there should be a way to query what the device support, |
This won't help as I need to know size of the sub-group before running the kernel to understand how much additional memory required. Should we disable the test for CUDA and HIP until we find a solution? |
Yeah we can do that |
While extending the original test did some refactoring: 1. Reduced types it tests 2. Test only 1 and 2 dimensions
While extending the original test did some refactoring: 1. Reduced types it tests 2. Test only 1 and 2 dimensions
While extending the original test did some refactoring: