This repository has been archived by the owner on Mar 28, 2023. It is now read-only.
forked from llvm/llvm-test-suite
-
Notifications
You must be signed in to change notification settings - Fork 131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
asudarsa
reviewed
Oct 19, 2022
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
asudarsa
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks
@kbobrovs Hey Konst do you mind merging this? I don't have permission, thanks! |
kbobrovs
reviewed
Oct 20, 2022
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
kbobrovs
reviewed
Oct 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with one minor note
kbobrovs
approved these changes
Oct 20, 2022
Nick, please ping me once the testing passes. |
@kbobrovs Looks like testing passed, mind merging? Thanks |
@sarnex - sure, done |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
Fix CMPLRTST-18426: remove /F when running with opt_use_cpu_O0
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
* [SYCL] Add double GRF test Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
* [SYCL] Add double GRF test Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corresponding test for intel/llvm#6914 which is already merged
I manually verified this test passes on PVC