Skip to content
This repository has been archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Add double GRF test #1328

Merged
merged 3 commits into from
Oct 20, 2022
Merged

[SYCL] Add double GRF test #1328

merged 3 commits into from
Oct 20, 2022

Conversation

sarnex
Copy link

@sarnex sarnex commented Oct 17, 2022

Corresponding test for intel/llvm#6914 which is already merged

I manually verified this test passes on PVC

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex sarnex marked this pull request as ready for review October 17, 2022 20:11
@sarnex sarnex requested a review from a team as a code owner October 17, 2022 20:11
@sarnex
Copy link
Author

sarnex commented Oct 19, 2022

@asudarsa Hey sorry do you mind reviewing this too? Just a system test that was requested in my other review. It's based on #1033

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Copy link

@asudarsa asudarsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

@sarnex
Copy link
Author

sarnex commented Oct 19, 2022

@kbobrovs Hey Konst do you mind merging this? I don't have permission, thanks!

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Copy link

@kbobrovs kbobrovs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one minor note

@kbobrovs
Copy link

@kbobrovs Hey Konst do you mind merging this? I don't have permission, thanks!

Nick, please ping me once the testing passes.

@sarnex
Copy link
Author

sarnex commented Oct 20, 2022

@kbobrovs Looks like testing passed, mind merging? Thanks

@kbobrovs kbobrovs merged commit 20b2dd3 into intel:intel Oct 20, 2022
@kbobrovs
Copy link

@sarnex - sure, done

myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
Fix CMPLRTST-18426: remove /F when running with opt_use_cpu_O0
myler pushed a commit to myler/llvm-test-suite that referenced this pull request Mar 22, 2023
* [SYCL] Add double GRF test

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
* [SYCL] Add double GRF test

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants